opendev/system-config
Code Issues Proposed changes

Enable Welcome Message to post review comments

Browse Source 
After extensive fixing from Jeremey and the Infrastructure
team, welcome message now detects newbies correctly.

The code has been run for a week in dry-run mode, and has
been verified to produce no false positives.

This patch removes the dry run option from the hook, to enable
welcome message to post welcoming messages on reviews from first-
time contributors.

Change-Id: I5dd072d36480294eefc23aa6376ae0a686621b08
This commit is contained in:
Tom Fifield 2014-03-13 09:58:13 +11:00
parent a6bf081ad8
commit 003f6cb477
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/openstack_project/templates/gerrit_patchset-created.erb
View File

@ -12,7 +12,7 @@ timeout -k 2m 10m /usr/local/bin/trivial-rebase \
--role-user=<%= trivial_rebase_role_id %> "$@"
<% end -%>
<% if $ssh_welcome_rsa_key_contents != "" -%>
timeout -k 2m 10m /usr/local/bin/welcome-message patchset-created --dryrun \
timeout -k 2m 10m /usr/local/bin/welcome-message patchset-created \
--verbose welcome-message@review.openstack.org \
/home/gerrit2/review_site/etc/ssh_welcome_rsa_key "$@"
<% end -%>