opendev/system-config
Code Issues Proposed changes

Check key exists before testing if it is true

Browse Source 
Change-Id: Ief6bdc0c96a477c72b1ad468198fcd033debac33
This commit is contained in:
Andrew Hutchings 2012-05-21 15:44:46 +01:00
parent 3974faa7e9
commit 016450abed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/jenkins_jobs/files/modules/trigger_gerrit.py
View File

@ -66,7 +66,7 @@ class trigger_gerrit(object):
XML.SubElement(gtrig, 'triggerOnChangeMergedEvent').text = trigger_data['triggerOnChangeMergedEvent']
XML.SubElement(gtrig, 'triggerOnCommentAddedEvent').text = trigger_data['triggerOnCommentAddedEvent']
XML.SubElement(gtrig, 'triggerOnRefUpdatedEvent').text = trigger_data['triggerOnRefUpdatedEvent']
if trigger_data['overrideVotes'] == 'true':
if trigger_data.has_key('overrideVotes') and trigger_data['overrideVotes'] == 'true':
XML.SubElement(gtrig, 'gerritBuildSuccessfulVerifiedValue').text = str(trigger_data['gerritBuildSuccessfulVerifiedValue'])
XML.SubElement(gtrig, 'gerritBuildFailedVerifiedValue').text = str(trigger_data['gerritBuildFailedVerifiedValue'])
if trigger_data['triggerOnCommentAddedEvent'] == 'true':