From 499af2c0cb707a8de420fe8ee39f2d2f5d4a2bc7 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Fri, 13 Jan 2023 08:39:37 -0800 Subject: [PATCH] Convert Verified MaxWithBlock to submit-requirement in testing Now that we've dropped gerrit 3.5 we can convert label functions to submit requirements. This is required for Gerrit 3.7 but is optional under 3.6. Eventually we'll need to do this for all of our custom labels prior to the 3.7 upgrade. Change-Id: I4dda45040842de76c12f36b5b6d6b5948d82077a --- playbooks/zuul/bootstrap-test-review.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/playbooks/zuul/bootstrap-test-review.yaml b/playbooks/zuul/bootstrap-test-review.yaml index e952a7839e..e923d3fd49 100644 --- a/playbooks/zuul/bootstrap-test-review.yaml +++ b/playbooks/zuul/bootstrap-test-review.yaml @@ -105,12 +105,15 @@ cat >> project.config << EOF [label "Verified"] - function = MaxWithBlock value = -2 Fails value = -1 Doesn't seem to work value = 0 No score value = +1 Works for me value = +2 Verified + [submit-requirement "Verified"] + description = CI result votes. Maximum required to merge and is provided by the Zuul's gate queue. + submittableIf = label:Verified=MAX AND -label:Verified=MIN + canOverrideInChildProjects = false [access "refs/heads/*"] label-Verified = -2..+2 group CI-tools EOF