From 258d6233a2451aaf4921acf679538dfd61bcad0c Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Sat, 18 Oct 2014 13:43:38 -0700 Subject: [PATCH] Bail out in run_all.sh runs when failures happen Previously the run_all.sh script would run puppet even if git is not properly updated or if our puppet modules fail to install. Now set -e in the script so that any failure to update git or install puppet modules causes run_all.sh to bail out early. This is important to ensure that we get consistent and expected results from puppet when it runs. Change-Id: Icb3fb2a97d11675762b49c57978b08115bfcbc04 --- run_all.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/run_all.sh b/run_all.sh index c51a0f3448..562248aef5 100755 --- a/run_all.sh +++ b/run_all.sh @@ -14,6 +14,10 @@ # License for the specific language governing permissions and limitations # under the License. +# If updating the puppet system-config repo or installing puppet modules +# fails then abort the puppet run as we will not get the results we +# expect. +set -e cd /opt/system-config/production git fetch -a && git reset -q --hard @{u}