From 2a85185bbc8d67feea888f4b286eb261510215d4 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Fri, 9 Oct 2020 09:48:24 -0700 Subject: [PATCH] Disable change.move and enableSignedPush in gerrit change.move is a new option in gerrit 3.0 that toggles whether or not the change move api is enabled. We disable it because there are potential confusing side effect for moving a change with parent changes then merging the moved change. Details can be found in https://bugs.chromium.org/p/gerrit/issues/detail?id=9877 We've not needed to move chagnes previously and users can abandon and push to a different branch instead. With enableSignedPush we set that to false even though it is an existing default because newer gerrit seems to write it out to its config file. We write it out to avoid unnecessary file updates after the upgrade. Note I believe it is safe to land this on 2.13 or 2.16 as gerrit should just ignore change.move until we get to 3.x and enableSignedPush already defaults to false. Change-Id: I9db2026b1e5cafefd448f33f74d6b7b60efafdb4 --- playbooks/roles/gerrit/templates/gerrit.config | 2 ++ 1 file changed, 2 insertions(+) diff --git a/playbooks/roles/gerrit/templates/gerrit.config b/playbooks/roles/gerrit/templates/gerrit.config index 0315ecb91c..290d276957 100644 --- a/playbooks/roles/gerrit/templates/gerrit.config +++ b/playbooks/roles/gerrit/templates/gerrit.config @@ -69,8 +69,10 @@ email = review@openstack.org [change] allowDrafts = false + move = false [receive] maxObjectSizeLimit = 100 m + enableSignedPush = false [commentlink "bugheader"] match = "([Cc]loses|[Pp]artial|[Rr]elated)-[Bb]ug:\\s*#?(\\d+)" link = "https://launchpad.net/bugs/$2"