opendev/system-config
Code Issues Proposed changes

Turn off color in module install

Browse Source 
This ends up putting a bunch of ansi escapes in the apply test
output. We could conditionally inject it form the apply test
if people want color when this is run normally.

Change-Id: I004bcd29671344430d271aad7f54186bc725215c
This commit is contained in:
Spencer Krum 2014-11-17 07:54:17 +00:00
parent ee18ccaca0
commit 3d4838ac33
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
install_modules.sh
View File

@ -60,7 +60,7 @@ if [ -z "${!MODULES[*]}" ] && [ -z "${!SOURCE_MODULES[*]}" ] ; then
exit 0 exit 0
fi fi
MODULE_LIST=`puppet module list` MODULE_LIST=`puppet module list --color=false`
# Transition away from old things # Transition away from old things
if [ -d /etc/puppet/modules/vcsrepo/.git ]; then if [ -d /etc/puppet/modules/vcsrepo/.git ]; then
@ -72,9 +72,9 @@ for MOD in ${!MODULES[*]} ; do
# If the module at the current version does not exist upgrade or install it. # If the module at the current version does not exist upgrade or install it.
if ! echo $MODULE_LIST | grep "$MOD ([^v]*v${MODULES[$MOD]}" >/dev/null 2>&1 ; then if ! echo $MODULE_LIST | grep "$MOD ([^v]*v${MODULES[$MOD]}" >/dev/null 2>&1 ; then
# Attempt module upgrade. If that fails try installing the module. # Attempt module upgrade. If that fails try installing the module.
if ! puppet module upgrade $MOD --version ${MODULES[$MOD]} >/dev/null 2>&1 ; then if ! puppet module upgrade $MOD --color=false --version ${MODULES[$MOD]} >/dev/null 2>&1 ; then
# This will get run in cron, so silence non-error output # This will get run in cron, so silence non-error output
puppet module install $MOD --version ${MODULES[$MOD]} >/dev/null puppet module install $MOD --color=false --version ${MODULES[$MOD]} >/dev/null
fi fi
fi fi
done done