From c7afea3e9efcf051b5cd65ca25450685a88cf450 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Fri, 22 Nov 2013 14:16:03 -0800 Subject: [PATCH] Remove +/-2 governance votes from tech committee No one on the tech committe has a veto power, therefore, no one should be able to leave a -2 vote. Given that constraint, there is no way to distinguishe a negative vote left by a tech committee member from a negative vote left by someone not on the committee. Therefore, give TC members the ability to vote +/-1 on review, remove the ability for non-members to vote (however they can and are welcome to leave comments!). The Chair alone may vote +2 on review and +1 on approve (both of which should be done if a motion passes). Change-Id: Id9accbc343a13b819c7e37532abc1140145699f0 --- .../files/gerrit/acls/openstack/governance.config | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/openstack_project/files/gerrit/acls/openstack/governance.config b/modules/openstack_project/files/gerrit/acls/openstack/governance.config index 63e2821e62..1efdb135ab 100644 --- a/modules/openstack_project/files/gerrit/acls/openstack/governance.config +++ b/modules/openstack_project/files/gerrit/acls/openstack/governance.config @@ -1,5 +1,7 @@ [access "refs/heads/*"] - label-Code-Review = -2..+2 group tech-committee + exclusiveGroupPermissions = label-Code-Review label-Approved + label-Code-Review = -1..+1 group tech-committee + label-Code-Review = -1..+2 group tech-committee-chair label-Approved = +0..+1 group tech-committee-chair workInProgress = group tech-committee [access "refs/tags/*"]