From df0a08f850757f89b9c847d964d142e681b22e15 Mon Sep 17 00:00:00 2001 From: Jeremy Stanley Date: Mon, 26 May 2014 23:53:22 +0000 Subject: [PATCH] Broaden recheck/reverify pattern for vote matching * modules/openstack_project/files/zuul/layout.yaml: Properly match votes in a Gerrit change comment. The previous pattern only matched a single negative or zeroed vote... cover positive votes and multiple vote types in the same comment too. Change-Id: Id8dc7fb4648e508598d2456f8877768281eef030 --- modules/openstack_project/files/zuul/layout.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/openstack_project/files/zuul/layout.yaml b/modules/openstack_project/files/zuul/layout.yaml index d25b17538e..33e8b6db52 100644 --- a/modules/openstack_project/files/zuul/layout.yaml +++ b/modules/openstack_project/files/zuul/layout.yaml @@ -15,7 +15,7 @@ pipelines: - event: patchset-created - event: change-restored - event: comment-added - comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\-]*)?(\n\n)?\s*recheck(( (?:bug|lp)[\s#:]*(\d+))|( no bug))\s*$ + comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\+-]*)*(\n\n)?\s*recheck(( (?:bug|lp)[\s#:]*(\d+))|( no bug))\s*$ - event: comment-added require-approval: - username: jenkins @@ -26,7 +26,7 @@ pipelines: - username: jenkins older-than: 24h - event: comment-added - comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\-]*)?(\n\n)?\s*reverify( (?:bug|lp)[\s#:]*(\d+))\s*$ + comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\+-]*)*(\n\n)?\s*reverify( (?:bug|lp)[\s#:]*(\d+))\s*$ require-approval: - workflow: 1 - username: jenkins @@ -137,7 +137,7 @@ pipelines: gerrit: - event: patchset-created - event: comment-added - comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\-]*)?(\n\n)?\s*recheck(( (?:bug|lp)[\s#:]*(\d+))|( no bug))\s*$ + comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\+-]*)*(\n\n)?\s*recheck(( (?:bug|lp)[\s#:]*(\d+))|( no bug))\s*$ - name: experimental description: On-demand pipeline for requesting a run against a set of jobs that are not yet gating. Leave review comment of "check experimental" to run jobs in this pipeline. @@ -146,7 +146,7 @@ pipelines: trigger: gerrit: - event: comment-added - comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\-]*)?(\n\n)?\s*check experimental\s*$ + comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\+-]*)*(\n\n)?\s*check experimental\s*$ success: gerrit: {} failure: @@ -207,7 +207,7 @@ pipelines: - event: patchset-created - event: change-restored - event: comment-added - comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\-]*)?(\n\n)?\s*recheck(( (?:bug|lp)[\s#:]*(\d+))|( no bug))\s*$ + comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\+-]*)*(\n\n)?\s*recheck(( (?:bug|lp)[\s#:]*(\d+))|( no bug))\s*$ - event: comment-added require-approval: - username: jenkins @@ -227,7 +227,7 @@ pipelines: trigger: gerrit: - event: comment-added - comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\-]*)?(\n\n)?\s*check experimental\s*$ + comment_filter: (?i)^(Patch Set [0-9]+:)?( [\w\\+-]*)*(\n\n)?\s*check experimental\s*$ success: gerrit: {} failure: