opendev/system-config
Code Issues Proposed changes

Reduce number of files send for propose_translation

Browse Source 
If a single file has changed, all other .pot files are send as well
since they have a new timestamp.

Check for files that only have a new timestamp and revert their change
so that they do not get committed at all.

Also, handle Project-Id-Version the same way as the timestamp.

Change-Id: I49488d01a7bb9242508ec7d378240449124608de
This commit is contained in:
Andreas Jaeger 2014-03-24 08:04:00 +01:00
parent 4784ff631d
commit a853bed193
2 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
modules/jenkins/files/slave_scripts/propose_translation_update.sh
View File

@ -59,9 +59,19 @@ fi
# Add all changed files to git
git add $PROJECT/locale/*
# Don't send a review if the only things which have changed are the creation
# date or comments.
if [ `git diff --cached | egrep -v "(POT-Creation-Date|^[\+\-]#|^\+{3}|^\-{3})" | egrep -c "^[\-\+]"` -gt 0 ]
# Don't send files where the only things that have changed are the
# creation date, the version number or comment lines.
for f in `git diff --cached --name-only`
do
if [ `git diff --cached $f |egrep -v "(POT-Creation-Date|Project-Id-Version|^\+{3}|^\-{3}|^[-+]#)" | egrep -c "^[\-\+]"` -eq 0 ]
then
git reset -q $f
git checkout -- $f
fi
done
# Don't send a review if nothing has changed.
if [ `git diff --cached |wc -l` -gt 0 ]
then
# Commit and review
git commit -F- <<EOF

16
modules/jenkins/files/slave_scripts/propose_translation_update_manuals.sh
View File

@ -94,9 +94,19 @@ do
fi
done
# Don't send a review if the only things which have changed are the creation
# date or comments.
if [ `git diff --cached | egrep -v "(POT-Creation-Date|^[\+\-]#|^\+{3}|^\-{3})" | egrep -c "^[\-\+]"` -gt 0 ]
# Don't send files where the only things which have changed are the
# creation date, the version number or comment lines.
for f in `git diff --cached --name-only`
do
if [ `git diff --cached $f |egrep -v "(POT-Creation-Date|Project-Id-Version|^\+{3}|^\-{3}|^[-+]#)" | egrep -c "^[\-\+]"` -eq 0 ]
then
git reset -q $f
git checkout -- $f
fi
done
# Don't send a review if nothing has changed.
if [ `git diff --cached |wc -l` -gt 0 ]
then
# Commit and review
git commit -F- <<EOF