From cc37e1f7b4b9f8b0eee1b8624969d3d43f5d6ad1 Mon Sep 17 00:00:00 2001
From: Ian Wienand <iwienand@redhat.com>
Date: Wed, 24 Feb 2021 16:50:46 +1100
Subject: [PATCH] zuul-summary-status : handle SKIPPED and ERROR jobs

Zuul reports SKIPPED jobs with a slightly different format, with a
fake URL and no run-time.

ERROR results include a message before the timestamp.

Update our test comments to reflect this, and the dependent change has
the updates for the zuul-summary-status plugin.

Depends-On: https://gerrit-review.googlesource.com/c/plugins/zuul-results-summary/+/298422
Change-Id: Idf2f12a8105c08f34a1600c66a3d7a26671728d2
---
 playbooks/test-review.yaml    | 3 ++-
 zuul.d/system-config-run.yaml | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/playbooks/test-review.yaml b/playbooks/test-review.yaml
index 1b3528fedc..0d5db35e48 100644
--- a/playbooks/test-review.yaml
+++ b/playbooks/test-review.yaml
@@ -179,7 +179,7 @@
             - test-success https://zuul.opendev.org/t/openstack/build/00b1ce7d5d994339a54dd8142a6813a6 : SUCCESS in {{ range(1, 59) | random }}m 22s
             - test-failure https://zuul.opendev.org/t/openstack/build/00b1ce7d5d994339a54dd8142a6813a6 : FAILURE in {{ range(1, 59) | random }}m 22s
             - test-retry-limit https://zuul.opendev.org/t/openstack/build/20efbb1b6983453884103e9628a70942 : RETRY_LIMIT in {{ range(1, 59) | random }}m 24s
-            - test-skipped https://zuul.opendev.org/t/openstack/build/43a00a7e190b4ce2b3e20a86166c011a : SKIPPED in {{ range(1, 59) | random }}m 40s
+            - test-skipped https://zuul.opendev.org/t/openstack/build/None : SKIPPED
             - test-aborted https://zuul.opendev.org/t/openstack/build/bc4a4559645b4088a9f8586c043c4764 : ABORTED in {{ range(1, 59) | random }}m 19s
             - test-merger-failure https://zuul.opendev.org/t/openstack/build/cb469750b250430b95a02697931d6030 : MERGER_FAILURE in {{ range(1, 59) | random }}m 14s
             - test-node-failure https://zuul.opendev.org/t/openstack/build/0897fafc9652480794652fc49e3c9baf : NODE_FAILURE in {{ range(1, 59) | random }}m 48s
@@ -187,6 +187,7 @@
             - test-post-failure https://zuul.opendev.org/t/openstack/build/30afb96669fe4f19b6215e79615ecd90 : POST_FAILURE in {{ range(1, 59) | random }}m 58s
             - test-config-error https://zuul.opendev.org/t/openstack/build/76c69b8062284d959a85b55bc460f822 : CONFIG_ERROR in {{ range(1, 59) | random }}m 27s
             - test-disk-full https://zuul.opendev.org/t/openstack/build/0897fafc9743580794652fc49e3c9baf : DISK_FULL in {{ range(1, 59) | random }}m 48s
+            - test-error https://zuul.opendev.org/t/openstack/build/0897bedc9743580794652fc49e3c1234 : ERROR This is an error message in {{ range(1, 59) | random }}m 32s
       loop:
         - 1
         - 2
diff --git a/zuul.d/system-config-run.yaml b/zuul.d/system-config-run.yaml
index 7b9eb5cc51..e3b70653f8 100644
--- a/zuul.d/system-config-run.yaml
+++ b/zuul.d/system-config-run.yaml
@@ -831,6 +831,7 @@
       - playbooks/install-ansible.yaml
       - playbooks/letsencrypt.yaml
       - playbooks/service-review.*.yaml
+      - playbooks/test-review.yaml
       - inventory/service/group_vars/review.yaml
       - inventory/service/host_vars/review\d+.openstack.org.yaml
       - inventory/service/group_vars/review-dev.yaml