From b683a5afd38a19760bb89bb4883278e0e91ec6a8 Mon Sep 17 00:00:00 2001 From: Monty Taylor Date: Fri, 18 Apr 2014 11:57:13 -0700 Subject: [PATCH] Properly don't fail on success When a thing is successful, we should not consider it to be a failure. Doing so will cause it to have further mental anguish and feelings of inadequacy. We don't support that sort of demeaning attitude in OpenStack. Change-Id: Ic92f5edf730297c200b916f21d0fe60dcab41d00 --- modules/openstack_project/templates/run_remote_puppet.sh.erb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/openstack_project/templates/run_remote_puppet.sh.erb b/modules/openstack_project/templates/run_remote_puppet.sh.erb index ad9334a43c..1dcf998c71 100755 --- a/modules/openstack_project/templates/run_remote_puppet.sh.erb +++ b/modules/openstack_project/templates/run_remote_puppet.sh.erb @@ -51,7 +51,9 @@ cd /opt/config/production # Run things that need to be ordered for host in $OVERRIDE_LIST; do - if run_ssh $host ; then + run_ssh $host + ret=$? + if [ $ret != 0 ] ; then break fi done