From 003f6cb4770be9ceb36aac06819c7c5dd4f2ca58 Mon Sep 17 00:00:00 2001 From: Tom Fifield Date: Thu, 13 Mar 2014 09:58:13 +1100 Subject: [PATCH] Enable Welcome Message to post review comments After extensive fixing from Jeremey and the Infrastructure team, welcome message now detects newbies correctly. The code has been run for a week in dry-run mode, and has been verified to produce no false positives. This patch removes the dry run option from the hook, to enable welcome message to post welcoming messages on reviews from first- time contributors. Change-Id: I5dd072d36480294eefc23aa6376ae0a686621b08 --- modules/openstack_project/templates/gerrit_patchset-created.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/openstack_project/templates/gerrit_patchset-created.erb b/modules/openstack_project/templates/gerrit_patchset-created.erb index 27fcab949d..6906d10dbc 100755 --- a/modules/openstack_project/templates/gerrit_patchset-created.erb +++ b/modules/openstack_project/templates/gerrit_patchset-created.erb @@ -12,7 +12,7 @@ timeout -k 2m 10m /usr/local/bin/trivial-rebase \ --role-user=<%= trivial_rebase_role_id %> "$@" <% end -%> <% if $ssh_welcome_rsa_key_contents != "" -%> -timeout -k 2m 10m /usr/local/bin/welcome-message patchset-created --dryrun \ +timeout -k 2m 10m /usr/local/bin/welcome-message patchset-created \ --verbose welcome-message@review.openstack.org \ /home/gerrit2/review_site/etc/ssh_welcome_rsa_key "$@" <% end -%>