opendev/system-config
Code Issues Proposed changes

Fix vhost configuration sections

Browse Source 
According to https://wiki.apache.org/httpd/CommonMisconfigurations
is is wrong to specify server name in opening tag. ServerName
should be used instead.

Indentations also fixed in some files.

Change-Id: Id9d20a672103221efa01be61a174b62706036e57
This commit is contained in:
Dmitry Teselkin 2014-10-31 09:25:09 +03:00
parent c37b392b95
commit d4589e1ed6
7 changed files with 46 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
modules/etherpad_lite/templates/etherpadlite.vhost.erb
View File

@ -1,4 +1,5 @@
<VirtualHost <%= scope.lookupvar("etherpad_lite::apache::vhost_name") %>:80> <VirtualHost *:80>
ServerName <%= scope.lookupvar("etherpad_lite::apache::vhost_name") %>
ServerAdmin <%= scope.lookupvar("etherpad_lite::apache::serveradmin") %> ServerAdmin <%= scope.lookupvar("etherpad_lite::apache::serveradmin") %>
ErrorLog ${APACHE_LOG_DIR}/<%= scope.lookupvar("etherpad_lite::apache::vhost_name") %>-error.log ErrorLog ${APACHE_LOG_DIR}/<%= scope.lookupvar("etherpad_lite::apache::vhost_name") %>-error.log
@ -12,7 +13,7 @@
</VirtualHost> </VirtualHost>
<IfModule mod_ssl.c> <IfModule mod_ssl.c>
<VirtualHost <%= scope.lookupvar("etherpad_lite::apache::vhost_name") %>:443> <VirtualHost *:443>
ServerName <%= scope.lookupvar("etherpad_lite::apache::vhost_name") %> ServerName <%= scope.lookupvar("etherpad_lite::apache::vhost_name") %>
ServerAdmin <%= scope.lookupvar("etherpad_lite::apache::serveradmin") %> ServerAdmin <%= scope.lookupvar("etherpad_lite::apache::serveradmin") %>

5
modules/gerrit/templates/gerrit.vhost.erb
View File

@ -1,4 +1,5 @@
<VirtualHost <%= scope.lookupvar("gerrit::vhost_name") %>:80> <VirtualHost *:80>
ServerName <%= scope.lookupvar("gerrit::vhost_name") %>
ServerAdmin <%= scope.lookupvar("gerrit::serveradmin") %> ServerAdmin <%= scope.lookupvar("gerrit::serveradmin") %>
ErrorLog ${APACHE_LOG_DIR}/gerrit-error.log ErrorLog ${APACHE_LOG_DIR}/gerrit-error.log
@ -12,7 +13,7 @@
</VirtualHost> </VirtualHost>
<IfModule mod_ssl.c> <IfModule mod_ssl.c>
<VirtualHost <%= scope.lookupvar("gerrit::vhost_name") %>:443> <VirtualHost *:443>
ServerName <%= scope.lookupvar("gerrit::vhost_name") %> ServerName <%= scope.lookupvar("gerrit::vhost_name") %>
ServerAdmin <%= scope.lookupvar("gerrit::serveradmin") %> ServerAdmin <%= scope.lookupvar("gerrit::serveradmin") %>
AllowEncodedSlashes NoDecode AllowEncodedSlashes NoDecode

2
modules/logstash/templates/kibana.vhost.erb
View File

@ -1,4 +1,4 @@
<VirtualHost <%= scope.lookupvar("::logstash::web::vhost_name") %>:80> <VirtualHost *:80>
ServerName <%= scope.lookupvar("::logstash::web::vhost_name") %> ServerName <%= scope.lookupvar("::logstash::web::vhost_name") %>
ServerAdmin <%= scope.lookupvar("::logstash::web::serveradmin") %> ServerAdmin <%= scope.lookupvar("::logstash::web::serveradmin") %>

2
modules/logstash/templates/logstash.vhost.erb
View File

@ -1,4 +1,4 @@
<VirtualHost <%= @vhost_name %>:80> <VirtualHost *:80>
ServerName <%= @vhost_name %> ServerName <%= @vhost_name %>
ServerAdmin <%= @serveradmin %> ServerAdmin <%= @serveradmin %>

3
modules/nodepool/templates/nodepool-log.vhost.erb
View File

@ -1,4 +1,5 @@
<VirtualHost <%= scope.lookupvar("nodepool::vhost_name") %>:80> <VirtualHost *:80>
ServerName <%= scope.lookupvar("nodepool::vhost_name") %>
DocumentRoot <%= scope.lookupvar("nodepool::image_log_document_root") %> DocumentRoot <%= scope.lookupvar("nodepool::image_log_document_root") %>
<Directory <%= scope.lookupvar("nodepool::image_log_document_root") %>> <Directory <%= scope.lookupvar("nodepool::image_log_document_root") %>>

5
modules/openstackid/templates/vhost.erb
View File

@ -1,4 +1,5 @@
<VirtualHost <%= scope.lookupvar("openstackid::vhost_name") %>:80> <VirtualHost *:80>
ServerName <%= scope.lookupvar("openstackid::vhost_name") %>
ServerAdmin <%= scope.lookupvar("openstackid::serveradmin") %> ServerAdmin <%= scope.lookupvar("openstackid::serveradmin") %>
ErrorLog ${APACHE_LOG_DIR}/openstackid-error.log ErrorLog ${APACHE_LOG_DIR}/openstackid-error.log
@ -10,7 +11,7 @@
</VirtualHost> </VirtualHost>
<IfModule mod_ssl.c> <IfModule mod_ssl.c>
<VirtualHost <%= scope.lookupvar("openstackid::vhost_name") %>:443> <VirtualHost *:443>
ServerName <%= scope.lookupvar("openstackid::vhost_name") %> ServerName <%= scope.lookupvar("openstackid::vhost_name") %>
ServerAdmin <%= scope.lookupvar("openstackid::serveradmin") %> ServerAdmin <%= scope.lookupvar("openstackid::serveradmin") %>

3
modules/zuul/templates/zuul.vhost.erb
View File

@ -1,4 +1,5 @@
<VirtualHost <%= scope.lookupvar("::zuul::vhost_name") %>:80> <VirtualHost *:80>
ServerName <%= scope.lookupvar("::zuul::vhost_name") %>
ServerAdmin <%= scope.lookupvar("::zuul::serveradmin") %> ServerAdmin <%= scope.lookupvar("::zuul::serveradmin") %>
DocumentRoot /var/lib/zuul/www DocumentRoot /var/lib/zuul/www