opendev/system-config
Code Issues Proposed changes

Set pipefail when running tox | tee.

Browse Source 
Pep8 tests had previously been run as `tox -v -epep8 | tee pep8.txt`
which would not fail if tox returned a non zero exit status because
pipes return the status of the last command by default. Set pipefail
to cause pep8 test failures to not be masked by tee.

Change-Id: I8441dbd431d0170b93e72e76d34b62d62b5d8286
This commit is contained in:
Clark Boylan 2012-07-09 12:35:42 -07:00
parent 1e565a85be
commit d5a43de82e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/jenkins_jobs/files/modules/builders.py
View File

@ -87,7 +87,7 @@ rm -fr ~/.java\n\
self._add_script(xml_parent, "./tools/version.sh --reset")
def _builder_pep8(self, xml_parent):
self._add_script(xml_parent, 'tox -v -epep8 | tee pep8.txt')
self._add_script(xml_parent, 'set -o pipefail ; tox -v -epep8 | tee pep8.txt ; set +o pipefail')
def _builder_pyflakes(self, xml_parent):
self._add_script(xml_parent, 'tox -v -epyflakes')