From d14c8492b6e880946d916fb70609bae3aa52ec56 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Mon, 30 Jan 2023 16:21:45 -0800 Subject: [PATCH] Switch Gerrit test Verified label function to NoBlock After reading through the Gerrit code I'm beginning to think that not setting a function has it default to MaxWithBlock and this doesn't get rejected like an explicit setting of MaxWith Block. This means we may not be properly exercising our new submit requirement rule for Verified. Switch it to NoBlock explicitly to exercise the submit requirements. Change-Id: I3296ba650c0c58326499604f1117916a990f0cf1 --- playbooks/zuul/bootstrap-test-review.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/playbooks/zuul/bootstrap-test-review.yaml b/playbooks/zuul/bootstrap-test-review.yaml index e923d3fd49..f4a94d0a68 100644 --- a/playbooks/zuul/bootstrap-test-review.yaml +++ b/playbooks/zuul/bootstrap-test-review.yaml @@ -105,6 +105,7 @@ cat >> project.config << EOF [label "Verified"] + function = NoBlock value = -2 Fails value = -1 Doesn't seem to work value = 0 No score