From d5a43de82e00e12c77b205af7144ca548a0c2b5d Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Mon, 9 Jul 2012 12:35:42 -0700 Subject: [PATCH] Set pipefail when running `tox | tee`. Pep8 tests had previously been run as `tox -v -epep8 | tee pep8.txt` which would not fail if tox returned a non zero exit status because pipes return the status of the last command by default. Set pipefail to cause pep8 test failures to not be masked by tee. Change-Id: I8441dbd431d0170b93e72e76d34b62d62b5d8286 --- modules/jenkins_jobs/files/modules/builders.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/jenkins_jobs/files/modules/builders.py b/modules/jenkins_jobs/files/modules/builders.py index bf808f67ec..5a19cbca73 100644 --- a/modules/jenkins_jobs/files/modules/builders.py +++ b/modules/jenkins_jobs/files/modules/builders.py @@ -87,7 +87,7 @@ rm -fr ~/.java\n\ self._add_script(xml_parent, "./tools/version.sh --reset") def _builder_pep8(self, xml_parent): - self._add_script(xml_parent, 'tox -v -epep8 | tee pep8.txt') + self._add_script(xml_parent, 'set -o pipefail ; tox -v -epep8 | tee pep8.txt ; set +o pipefail') def _builder_pyflakes(self, xml_parent): self._add_script(xml_parent, 'tox -v -epyflakes')