From 3f1491d1e4c3ad1b3ecde516259abb0c95f24039 Mon Sep 17 00:00:00 2001 From: Jeremy Stanley Date: Thu, 10 Jul 2014 21:32:44 +0000 Subject: [PATCH] Git rev-list --max-count needs an = for assignment * install_modules.sh: When invoking git rev-list with --max-count it only supports = and not space before the value. The previous implementation was flawed and only ever resulted in git errors about an unrecognized ref for which it was misinterpreting the --max-count value as representing. Change-Id: I11f8f5b6e13d4640d6558f423292ad7e7b89961f --- install_modules.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install_modules.sh b/install_modules.sh index 44c63a79dd..4e36d8fe7d 100755 --- a/install_modules.sh +++ b/install_modules.sh @@ -109,7 +109,7 @@ for MOD in ${!SOURCE_MODULES[*]} ; do # fetch the latest refs from the repo $GIT_CMD_BASE fetch # make sure the correct revision is installed, I have to use rev-list b/c rev-parse does not work with tags - if [ `${GIT_CMD_BASE} rev-list HEAD --max-count 1` != `${GIT_CMD_BASE} rev-list ${SOURCE_MODULES[$MOD]} --max-count 1` ]; then + if [ `${GIT_CMD_BASE} rev-list HEAD --max-count=1` != `${GIT_CMD_BASE} rev-list ${SOURCE_MODULES[$MOD]} --max-count=1` ]; then # checkout correct revision $GIT_CMD_BASE checkout ${SOURCE_MODULES[$MOD]} fi