opendev/system-config
Code Issues Proposed changes

Run puppet apply test serially on centos

Browse Source 
There appears to be a race running the ansible synchronize (rsync under
the hood) top copy puppet modules for multiple puppet applies at the
same time on CentOS7. Running this in parallel appears safe on Ubuntu
and does save quite a bit of job runtime.

Workaround this by running the apply test serially on CentOS only.

Change-Id: Icd0836db215c0b417989d38994a378a705bbc62b
This commit is contained in:
Clark Boylan 2018-09-05 15:31:36 -07:00
parent af7a431f5b
commit f9e18bc348
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/apply-test.sh
View File

@ -69,8 +69,16 @@ sudo mkdir -p /var/run/puppet
echo "Running apply test primer to avoid setup races when run in parallel."
./tools/test_puppet_apply.sh applytest/primer.pp
THREADS=$(nproc)
if grep -qi centos /etc/os-release ; then
# Single thread on centos to workaround a race with rsync on centos
# when copying puppet modules for multiple puppet applies at the same
# time.
THREADS=1
fi
echo "Running apply test on these hosts:"
find applytest -name 'puppetapplytest*.final' -print0
find applytest -name 'puppetapplytest*.final' -print0 | \
xargs -0 -P $(nproc) -n 1 -I filearg \
xargs -0 -P $THREADS -n 1 -I filearg \
./tools/test_puppet_apply.sh filearg