From 52094c441db091d9bceb3312a791f5d50ab64be5 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Fri, 9 Oct 2020 10:47:05 -0700 Subject: [PATCH] Clean up old Gerrit html theming and commentlinks When we get to Gerrit 3.x the old html theming, hideci.js and commentlinks that parse html and rely on urls no longer work. Lets clean that up when we get there. We can add back in similar things that polygerrit does support later but we don't want that to make the upgrade even more difficult to do. This should only be merged once we are running Gerrit 3.x. Change-Id: I838840e6cbf09ca28faeb2cf06290e298a4a1f74 --- .../roles/gerrit/files/etc/GerritSite.css | 179 - .../gerrit/files/etc/GerritSiteHeader.html | 6 - playbooks/roles/gerrit/files/static/hideci.js | 575 - .../gerrit/files/static/jquery-visibility.js | 88 - playbooks/roles/gerrit/files/static/jquery.js | 10351 ---------------- playbooks/roles/gerrit/files/static/title.svg | 56 - playbooks/roles/gerrit/tasks/main.yaml | 6 - .../roles/gerrit/templates/gerrit.config | 12 - 8 files changed, 11273 deletions(-) delete mode 100644 playbooks/roles/gerrit/files/etc/GerritSite.css delete mode 100644 playbooks/roles/gerrit/files/etc/GerritSiteHeader.html delete mode 100644 playbooks/roles/gerrit/files/static/hideci.js delete mode 100644 playbooks/roles/gerrit/files/static/jquery-visibility.js delete mode 100644 playbooks/roles/gerrit/files/static/jquery.js delete mode 100644 playbooks/roles/gerrit/files/static/title.svg diff --git a/playbooks/roles/gerrit/files/etc/GerritSite.css b/playbooks/roles/gerrit/files/etc/GerritSite.css deleted file mode 100644 index c1c9d47575..0000000000 --- a/playbooks/roles/gerrit/files/etc/GerritSite.css +++ /dev/null @@ -1,179 +0,0 @@ -body {color: #000 !important;} -a,a:visited {color: #264D69 !important; text-decoration: none;} -a:hover {color: #000 !important; text-decoration: underline} - -a.gwt-InlineHyperlink {background: none !important} - -#openstack-logo img { height: 40px; } -#openstack-logo h1 { margin: 20px; } -#gerrit_header #openstack-logo h1 { margin: 20px 0 0 0; } - -#gerrit_header {display: block !important; position: relative; top: -60px; margin-bottom: -60px; width: 200px; padding-left: 17px} -#gerrit_header h1 {font-family: 'PT Sans', sans-serif; font-weight: normal; letter-spacing: -1px} - -#gerrit_topmenu {background: none; position:relative; top: 0px; left: 220px; margin-right: 220px} - -#gerrit_topmenu tbody tr td table {border: 0} - -#gerrit_topmenu tbody tr td table.gwt-TabBar {color: #353535; border-bottom: 1px solid #C5E2EA;} -#gerrit_topmenu .gwt-Button {padding: 3px 6px} -.gwt-TabBarItem-selected {color: #CF2F19 !important; border-bottom: 3px solid #CF2F19;} -.gwt-TabBarItem {color: #353535; border-right: 0 !important} -.gwt-TabBar .gwt-TabBarItem, .gwt-TabBar .gwt-TabBarRest, .gwt-TabPanelBottom {background: 0 !important;} - -#gerrit_topmenu .searchTextBox {width: 250px} - -#change_infoTable { - border-collapse: collapse; -} - -#change_infoTable th { - padding: 2px 4px 2px 6px; - background-color: #eef3f5; - font-style: italic; - text-align: left; -} - -#change_infoTable td { - padding: 2px 4px 2px 6px; - border-bottom: 1px solid #eef3f5; - border-right: 1px solid #eef3f5; -} - -#change_infoTable tr:last-child td { - border: none; -} - -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 { - padding-left: 10px; - padding-right: 10px; -} - -/* Section headers */ -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-headerLine, -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-sectionHeader { - margin-top: 10px !important; - margin-bottom: 10px !important; -} - -/* Commit message */ -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-text::first-line { - font-weight: bold !important; -} - -/* Commit metadata */ -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-commitColumn - .com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-header th { - padding: 2px 4px 2px 6px; - background-color: #eef3f5; - font-style: italic; - text-align: left; -} - -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-commitColumn - .com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-header td { - border-bottom: 1px solid #eef3f5; - padding: 2px 4px 2px 6px; -} - -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-commitColumn - .com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-header td:last-child { - border-right: 1px solid #eef3f5; -} - -/* increase the middle info column to fill empty space (for wide -monitors), but ensure there is a sufficient lower bound to kick in -horiz scroll bar. This will relieve the preasure on the hideci test -results. */ -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-infoColumn { - width: 100% !important; - min-width: 400px; -} - -/* Review history */ -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-Message_BinderImpl_GenCss_style-name { - font-weight: bold !important; -} -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-Message_BinderImpl_GenCss_style-messageBox { - width: inherit; - max-width: 1168px; -} - -.comment_test_name { - display: inline-block; - *display: inline; - *zoom: 1; - width: auto !important; - width: 25em; - min-width: 20em; - padding-bottom: 2pt; -} - -.comment_test_result { -} - -.result_SUCCESS { - color: #007f00; -} -.result_FAILURE, .result_POST_FAILURE, .result_TIMED_OUT, .result_RETRY_LIMIT, .result_DISK_FULL { - color: #cf2f19; -} -.result_UNSTABLE, .result_WARNING { - color: #e39f00; -} -.result_LOST { - color: #e39f00; -} -li.comment_test {list-style-type: none; } - -/* this is for support of 'Display Person Name In Review Category' */ -.cAPPROVAL { - max-width: 100px; - overflow: hidden; -} -/* fixes to make this like old gerrit */ -.changeTable td.dataCell { - height: 1em; -} - -/* don't make the non voting stand out more than the voting */ -table.infoTable td.notVotable, -.changeTable td.dataCell.labelNotApplicable { - background: inherit; -} - -.test_result_table { - border-collapse: collapse; -} - -.test_result_table tr { - border-left: 1px solid #eef3f5; - border-right: 1px solid #eef3f5; -} - -.test_result_table td.header { - background-color: #eef3f5; -} - -.test_result_table td { - padding: 2px 4px 2px 6px; - border: 1px solid #eef3f5; -} - -.addMemberTextBox { - width: 20em; -} - -/* css attribute selector to make -1s show up red in new screen */ -[title="Doesn't seem to work"], -[title="This patch needs further work before it can be merged"] { - color: red; -} diff --git a/playbooks/roles/gerrit/files/etc/GerritSiteHeader.html b/playbooks/roles/gerrit/files/etc/GerritSiteHeader.html deleted file mode 100644 index 0e2f060fa8..0000000000 --- a/playbooks/roles/gerrit/files/etc/GerritSiteHeader.html +++ /dev/null @@ -1,6 +0,0 @@ -