Mostly documentation and parameterised class parameter complaints.
Change-Id: I5b3ffa4ad3f707f385165c2d86c891c6bd4c1ae0
Reviewed-on: https://review.openstack.org/16901
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Change-Id: I49e63755b8b5bf60673cf37b62371b3f299e3bbe
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/14971
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
More fixes in preparation for our gate-ci-puppet-lint job.
Change-Id: I1cd3499e6cd958fbbacd01f3daef581a7b4d3217
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/13764
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Pip doesn't appear to be able to do a clean upgrade of gerritbot on
oneiric. It should remove the old versions of gerritbot after installing
the new versions but it does not. This confuses Puppet into thinking
that it need to reinstall gerritbot 0.1.2 on each puppet run which
restarts the IRC bot. To prevent this behavior ensure the package is
present and not latest.
Change-Id: I7729d126a7811b7e08541ed65ca48f4dc302ff6b
Reviewed-on: https://review.openstack.org/11955
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Configure gerritbot to log into /var/log/gerritbot.
Change-Id: I24f8602eaa0f779de9d455cda8ad692f932ebd39
Reviewed-on: https://review.openstack.org/11939
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
gerritbot.confg should be gerritbot.config
Change-Id: I9532226a690a986ae8480c1cfbd89e23cf1f3ac1
Reviewed-on: https://review.openstack.org/11905
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Stop using the gerritbot script within the puppet tree. Use the
upstream gerritbot implementation from pypi instead.
Remove old gerritbot script, use pip to install upstream gerritbot,
and update init script to find new location, of the gerritbot script.
Change-Id: I62afe404b1c4d130901e54ca4e7857bb71b4cdd8
Reviewed-on: https://review.openstack.org/10676
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
