5 Commits

Author SHA1 Message Date
Jeremy Stanley
258e8e8585 Retool accessbot for OFTC
A number of changes are needed to fit accessbot to OFTC's RBAC-style
permissions model and services syntax expectations. Most
importantly, access list entries now use role names for graduated
access tiers (member, chanop, master) rather than fine-grained
option flags. In order to avoid future confusion, switch variable
names and configuration keys to reflect that these are access levels
rather than masks.

While we're at it, skip setting the channel mlock if the result
would be a no-op, so that we don't unnecessarily spam the ircd with
pointless writes.

Also add a bunch of inline comments so I can more easily remember
the subtle nuances I spent a lot of time figuring out.

Change-Id: Id11598fc42672359e1abef7b70cc23100b16ab12
Depends-on: https://review.opendev.org/792843
2021-05-28 02:06:34 +00:00
Clark Boylan
421a71e145 Be explicit about using python3 in docker images
Our docker python-base image is a python3 image where python and python3
point to the same version of python which happens to be a 3.x depending
on the specific base image.

One of the things that came up at the PTG is that we'd like to start
identifying where we use python2 in order to port to python3. That is
made a bit more difficult when we use `python` assuming it is `python3`
as we do in our docker images.

Update the images to use `python3` to make this a lot more explicit and
clear that we don't need to port these items.

Change-Id: I54e8f128f0cb8fbbdf54e3748384470262bef3a9
2020-06-09 09:30:56 -07:00
Andreas Jaeger
90fa9170dd Fix py3 problem in accessbot.py
Change-Id: I4e3b3683b33b600cc4c1e4f09ba02c59e6f5cbb9
Fix:
TypeError: unsupported operand type(s) for +: 'dict_items' and 'dict_items'
2020-05-02 22:11:21 +02:00
Andreas Jaeger
26f1dae81b Fix accessbot/Dockerfile
The command is broken (extra ", misses redirection) and duplicates
content from accessbot.sh. Call accessbot.sh directly and use that one
instead.

Change-Id: Ieb530ef27e5995f2848a3c23a6c04a0717716e14
2020-05-02 18:02:06 +02:00
Monty Taylor
9fd2135a46 Split eavesdrop into its own playbook
Extract eavedrop into its own service playbook and
puppet manifest. While doing that, stop using jenkinsuser
on eavesdrop in favor of zuul-user.

Add the ability to override the keys for the zuul user.

Remove openstack_project::server, it doesn't do anything.

Containerize and anisblize accessbot. The structure of
how we're doing it in puppet makes it hard to actually
run the puppet in the gate. Run the script in its own
playbook so that we can avoid running it in the gate.

Change-Id: I53cb63ffa4ae50575d4fa37b24323ad13ec1bac3
2020-04-23 14:34:28 -05:00