More fixes in preparation for our gate-ci-puppet-lint job.
Change-Id: I1cd3499e6cd958fbbacd01f3daef581a7b4d3217
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/13764
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Fix several formatting issues following the guideline of PEP8:
1. List the import statements in alphabetical order.
2. Fix a lot of indentation issues.
3. Adjust the length of several lines.
4. Other PEP8 issues fixed.
Change-Id: I8fefa4db882d4fb72146052852a27b6994fc5d5b
Reviewed-on: https://review.openstack.org/12250
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
Delete update_users.py since this script is not used any more.
Use update_gerrit_users.py instead.
Change-Id: Ie72b565df058a34e044921288013498b5be9477e
Reviewed-on: https://review.openstack.org/12487
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
The development endpoint for the LP api has been in use for about a week
giving is log data on its performance. Switch to the non development
endpoint to gather data on that endpoint.
Change-Id: I153dd396feddba47ea7576e53e6f34172732c02d
Reviewed-on: https://review.openstack.org/12141
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Use the logging package to properly log in the lp to gerrit user sync
script.
Change-Id: I329ea96a5257f7ea140406127b27621dd0253c09
Reviewed-on: https://review.openstack.org/11663
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
Add rudimentary logging to the gerrit user sync script. Log the start
and stop times of script runs. Also modify timeout in the cronjob to
allow the job to run for up to 8 hours in order to get better log data.
Change-Id: I193911e2d4dcd6448ef8a61360e6fc9fff287c1a
Reviewed-on: https://review.openstack.org/11658
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
For consistency use development version of the LP API in the scripts
that query the Launchpad API.
Change-Id: I39b145684563738dd5615d863720ec364c4987c3
Reviewed-on: https://review.openstack.org/11508
Reviewed-by: linuxjedi <andrew@linuxjedi.co.uk>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
The gerrit user sync script is showing the same symptoms as the gerrit
hook scripts when it comes to hanging on a launchpad connection.
Timeout this script as well so that it can be run again instead of
perpetually doing nothing.
Change-Id: I8d44c6eac76f5820f28eb1723640ce4dac57413b
Reviewed-on: https://review.openstack.org/11503
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Also, moved depends for launchpad sync script to the launchpad sync
module, and put the ntp stuff into an ntp module.
Change-Id: I2568752493fefa305f9108a23da101d80a311552
Additionally, the file installation of the scripts wasn't working,
so the sync script wasn't actually getting installed. This moves
the underlying scripts to be installed by the gerrit module,
because it owns /usr/local/gerrit/scripts, and then manages the
gerrit hooks which call those scripts in the openstack_project
class, since that's where the config choice to enable those
functions really should live.
Change-Id: I54fb9edd9fb0c634d8d9de4e57f9ddad6af63a99
