openstack/cinder
Code Issues Proposed changes

Merge "Pylint: refactor ignored message lists"

Browse Source
This commit is contained in:
Jenkins 2016-04-19 08:39:52 +00:00 committed by Gerrit Code Review
commit 0f9cf6c20c
1 changed files with 29 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
tools/lintstack.py
View File

@ -26,25 +26,35 @@ from pylint import lint
from pylint.reporters import text from pylint.reporters import text
from six.moves import cStringIO as StringIO from six.moves import cStringIO as StringIO
# Note(maoy): E1103 is error code related to partial type inference ignore_codes = [
ignore_codes = ["E1103"] # Note(maoy): E1103 is error code related to partial type inference
# Note(maoy): the error message is the pattern of E0202. It should be ignored "E1103"
# for cinder.tests modules ]
# Note(fengqian): the second error message is the pattern of [E0611].
# It should be ignored because use six module to keep py3.X compatibility. ignore_messages = [
# Note(e0ne): the third error message is for SQLAlchemy update() calls # Note(maoy): this error message is the pattern of E0202. It should be
# in DB schema migrations. # ignored for cinder.tests modules
# Note(xyang): the fourth and fifth error messages are for the code [E1101]. "An attribute affected in cinder.tests",
# They should be ignored because 'sha256' and 'sha224' are functions in
# 'hashlib'. # Note(fengqian): this error message is the pattern of [E0611].
# Note(aarefiev): the sixth error message is for SQLAlchemy rename calls in "No name 'urllib' in module '_MovedItems'",
# DB migration(033_add_encryption_unique_key).
ignore_messages = ["An attribute affected in cinder.tests", # Note(e0ne): this error message is for SQLAlchemy update() calls
"No name 'urllib' in module '_MovedItems'", # It should be ignored because use six module to keep py3.X compatibility.
"No value passed for parameter 'dml'", # in DB schema migrations.
"Module 'hashlib' has no 'sha256' member", "No value passed for parameter 'dml'",
"Module 'hashlib' has no 'sha224' member",
"Instance of 'Table' has no 'rename' member"] # Note(xyang): these error messages are for the code [E1101].
# They should be ignored because 'sha256' and 'sha224' are functions in
# 'hashlib'.
"Module 'hashlib' has no 'sha256' member",
"Module 'hashlib' has no 'sha224' member",
# Note(aarefiev): this error message is for SQLAlchemy rename calls in
# DB migration(033_add_encryption_unique_key).
"Instance of 'Table' has no 'rename' member"
]
# Note(maoy): We ignore cinder.tests for now due to high false # Note(maoy): We ignore cinder.tests for now due to high false
# positive rate. # positive rate.
ignore_modules = ["cinder/tests/"] ignore_modules = ["cinder/tests/"]