openstack/cinder
Code Issues Proposed changes

Fix cannot add a column with non-constant default

Browse Source 
With newer versions of sqlite tests are failing
on sqlite3.OperationalError : Cannot add a column with
non-constant default. In SQL queries is boolean without
apostrophes which causes sqlite3 error. This fix is
solving this issue by replacing text('false') to
expression.false() from sqlalchemy.sql which is
working correct.

Change-Id: Ia96255a2a61994a18b21acc235931ad03a8501ea
Closes-Bug: #1773123
This commit is contained in:
Michal Arbet 2018-05-24 11:52:55 +02:00
parent 910f534382
commit 2880e0b8c3
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cinder/db/sqlalchemy/migrate_repo/versions/088_add_replication_info_to_cluster.py
View File

@ -13,7 +13,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from sqlalchemy import Boolean, Column, MetaData, String, Table, text
from sqlalchemy import Boolean, Column, MetaData, String, Table
from sqlalchemy.sql import expression
def upgrade(migrate_engine):
@ -26,7 +27,7 @@ def upgrade(migrate_engine):
default="not-capable")
active_backend_id = Column('active_backend_id', String(length=255))
frozen = Column('frozen', Boolean, nullable=False, default=False,
server_default=text('false'))
server_default=expression.false())
clusters.create_column(replication_status)
clusters.create_column(frozen)