From 2cd5957c5e891f0bc5cf57253c0f5e18b330e954 Mon Sep 17 00:00:00 2001 From: Gorka Eguileor Date: Tue, 11 Sep 2018 22:17:49 +0200 Subject: [PATCH] Add comment to online data migration command One of the requirements of the online data migration command is that they must be able to be run without any Cinder service running in order to support a normal upgrade or a Fast-Forward upgrade. With the introduction of the shared_targets feature we added an online migration that requires the Cinder services to be running (it does RPC calls). To prevent this from happening again this patch adds a comment right above the online_migrations tupple as a reminder for reviewers. Change-Id: I911ddee5a62edc95bedbfd644804abd8b206e957 --- cinder/cmd/manage.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cinder/cmd/manage.py b/cinder/cmd/manage.py index 5678fc07a04..f401b1ab77c 100644 --- a/cinder/cmd/manage.py +++ b/cinder/cmd/manage.py @@ -259,6 +259,9 @@ class HostCommands(object): class DbCommands(object): """Class for managing the database.""" + # NOTE: Online migrations cannot depend on having Cinder services running. + # Migrations can be called during Fast-Forward Upgrades without having any + # Cinder services up. online_migrations = ( # Added in Queens db.service_uuids_online_data_migration,