From c24fde5ce9e1746b0372131a42363c53fe95a0c3 Mon Sep 17 00:00:00 2001 From: zhangdaolong Date: Wed, 5 Jul 2017 15:58:56 +0800 Subject: [PATCH] Fix Log parameter instance_id is easy to misunderstand as VM ID, and it doesn't agree with reality,and i think It's better to log attachment id. Change-Id: I22481731cacf7c4793e43713291f4c25c1e5afbb --- cinder/volume/manager.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cinder/volume/manager.py b/cinder/volume/manager.py index e9168a829c5..a4672858009 100644 --- a/cinder/volume/manager.py +++ b/cinder/volume/manager.py @@ -2215,11 +2215,11 @@ class VolumeManager(manager.CleanableManager, self.detach_volume(ctxt, volume.id, attachment.id) except Exception as ex: LOG.error("Detach migration source volume " - "%(volume.id)s from instance " - "%(instance_id)s failed: %(err)s", + "%(volume.id)s from attachment " + "%(attachment.id)s failed: %(err)s", {'err': ex, 'volume.id': volume.id, - 'instance_id': attachment.id}, + 'attachment.id': attachment.id}, resource=volume) # Give driver (new_volume) a chance to update things as needed