From e8f1b419a4c28c87911063956053fae60c0f9a65 Mon Sep 17 00:00:00 2001 From: Thomas Bechtold Date: Tue, 4 Jul 2017 15:16:10 +0000 Subject: [PATCH] Revert "Don't use ignoreskipactivation for thin LVM" Commit 8f5e10d7ed8eead221cccb6a0ccf1afea310b0a9 wrongly assumed that the "ignoreskipactivation" flag is not needed when using thin LVM provisioning. This is wrong. Using thin LVM leads now to an error when the content will be copied: ERROR cinder.volume.manager Command: sudo cinder-rootwrap /etc/cinder/ rootwrap.conf dd if=/dev/mapper/cinder--volumes-_snapshot--UUID of=/dev/mapper/cinder--volumes-volume--UUID count=1073741824 bs=1M iflag=count_bytes conv=sparse The reason is that the the snapshot is not activated and due to that, no device node is available under /dev/mapper . This reverts commit 8f5e10d7ed8eead221cccb6a0ccf1afea310b0a9 and makes thin provisioning for LVM working again. Change-Id: I788b297af92e11063b18c05a415b6f4d4d4bcd2c Closes-Bug: #1702322 Related-Bug: #1701545 --- cinder/brick/local_dev/lvm.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cinder/brick/local_dev/lvm.py b/cinder/brick/local_dev/lvm.py index 83bf254e2ed..78db70078ed 100644 --- a/cinder/brick/local_dev/lvm.py +++ b/cinder/brick/local_dev/lvm.py @@ -672,8 +672,7 @@ class LVM(executor.Executor): # and fails. cmd = ['lvchange', '-a', 'y', '--yes'] - if (self.supports_lvchange_ignoreskipactivation and - self.vg_thin_pool is None): + if self.supports_lvchange_ignoreskipactivation: cmd.append('-K') # If permanent=True is specified, drop the skipactivation flag in # order to make this LV automatically activated after next reboot.