openstack/cinder
Code Issues Proposed changes

Tests: Fix os.path.exists mock (emc_vnxdirect)

Browse Source 
Use mock rather than assigning to os.path.exists,
since this may cause later tests to break.

Change-Id: I028aee93c92d5fafb4da018925d20db18c962eed
This commit is contained in:
Eric Harney 2015-08-06 16:31:41 -06:00
parent 3a8b27c752
commit 6f04677640
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/tests/unit/test_emc_vnxdirect.py
View File

@ -2200,9 +2200,9 @@ Time Remaining: 0 second(s)
] ]
fake_cli.assert_has_calls(expected) fake_cli.assert_has_calls(expected)
def test_terminate_connection(self): @mock.patch('os.path.exists', return_value=True)
def test_terminate_connection(self, _mock_exists):
os.path.exists = mock.Mock(return_value=1)
self.driver = emc_cli_iscsi.EMCCLIISCSIDriver( self.driver = emc_cli_iscsi.EMCCLIISCSIDriver(
configuration=self.configuration) configuration=self.configuration)
cli_helper = self.driver.cli._client cli_helper = self.driver.cli._client