From 176f9b17b9e3cc22f17ae7200156491a29fc8fc5 Mon Sep 17 00:00:00 2001 From: ghanshyam Date: Tue, 21 Nov 2017 10:50:19 +0300 Subject: [PATCH] Fix group_type_id in api-ref group_type_id in GET/DELETE/PUT /group_types/group_type_id is mentioned as optional path variable which is not true. - https://github.com/openstack/cinder/blob/7c66eb3d976048e7179fedb7694a989c9181c374/cinder/api/v3/group_types.py#L101 This id is mandatory and doc should be updated. This create confusion while test case or using this API, example - https://review.openstack.org/#/c/521634/4/tempest/lib/services/volume/v3/group_types_client.py Closes-Bugs: # 1733504 Change-Id: I220cd20fefbe83ba8c392ab6b1679620d6a1d934 --- api-ref/source/v3/group-types.inc | 6 +++--- api-ref/source/v3/parameters.yaml | 6 ------ 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/api-ref/source/v3/group-types.inc b/api-ref/source/v3/group-types.inc index 25e4b91c723..6ac1808ebef 100644 --- a/api-ref/source/v3/group-types.inc +++ b/api-ref/source/v3/group-types.inc @@ -25,7 +25,7 @@ Request .. rest_parameters:: parameters.yaml - project_id: project_id_path - - group_type_id: group_type_id + - group_type_id: group_type_id_1 - group_type: group_type - name: name_16 - description: description_12 @@ -74,7 +74,7 @@ Request .. rest_parameters:: parameters.yaml - project_id: project_id_path - - group_type_id: group_type_id + - group_type_id: group_type_id_1 Response Parameters @@ -114,7 +114,7 @@ Request .. rest_parameters:: parameters.yaml - - group_type_id: group_type_id + - group_type_id: group_type_id_1 - project_id: project_id_path diff --git a/api-ref/source/v3/parameters.yaml b/api-ref/source/v3/parameters.yaml index 0a9381428de..3c555c4b526 100644 --- a/api-ref/source/v3/parameters.yaml +++ b/api-ref/source/v3/parameters.yaml @@ -67,12 +67,6 @@ group_snapshot_id: in: path required: true type: string -group_type_id: - description: | - The UUID for an existing group type. - in: path - required: false - type: string group_type_id_1: description: | The UUID for an existing group type.