openstack/cinder
Code Issues Proposed changes

Log terminate_connection exception with traceback

Browse Source 
The volume manager is not logging a traceback for
volume driver terminate_connection failures.

This can result in an opaque error message which
is hard to troubleshoot.

Closes-Bug: #1598214
Change-Id: Ibde64e0715cc861b73434e6a9c676c7e25a37a18
This commit is contained in:
Eric Harney 2016-07-01 10:55:42 -04:00
parent c249ccbe37
commit 81066a05df
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/volume/manager.py
View File

@ -1428,7 +1428,7 @@ class VolumeManager(manager.SchedulerDependentManager):
except Exception as err: except Exception as err:
err_msg = (_('Terminate volume connection failed: %(err)s') err_msg = (_('Terminate volume connection failed: %(err)s')
% {'err': six.text_type(err)}) % {'err': six.text_type(err)})
LOG.error(err_msg, resource=volume_ref) LOG.exception(err_msg, resource=volume_ref)
raise exception.VolumeBackendAPIException(data=err_msg) raise exception.VolumeBackendAPIException(data=err_msg)
LOG.info(_LI("Terminate volume connection completed successfully."), LOG.info(_LI("Terminate volume connection completed successfully."),
resource=volume_ref) resource=volume_ref)