Fix comments style according to the Hacking Rules
According to the PEP8(E265) there should be at least one space before block comment. Change-Id: Ic51f80210becc375b30f0f4e9eeb54995775c817 Partial-Bug: #1407162
This commit is contained in:
parent
2501bf5191
commit
84afca21fd
@ -217,7 +217,7 @@ class QoSSpecsController(wsgi.Controller):
|
||||
|
||||
force = req.params.get('force', None)
|
||||
|
||||
#convert string to bool type in strict manner
|
||||
# Convert string to bool type in strict manner
|
||||
force = strutils.bool_from_string(force)
|
||||
LOG.debug("Delete qos_spec: %(id)s, force: %(force)s" %
|
||||
{'id': id, 'force': force})
|
||||
|
@ -26,7 +26,7 @@ from cinder.openstack.common import log as logging
|
||||
from cinder import wsgi
|
||||
|
||||
|
||||
#default request size is 112k
|
||||
# Default request size is 112k
|
||||
max_request_body_size_opt = cfg.IntOpt('osapi_max_request_body_size',
|
||||
default=114688,
|
||||
help='Max size for body of a request')
|
||||
|
@ -389,7 +389,6 @@ class FileNotFound(NotFound):
|
||||
message = _("File %(file_path)s could not be found.")
|
||||
|
||||
|
||||
#TODO(bcwaldon): EOL this exception!
|
||||
class Duplicate(CinderException):
|
||||
pass
|
||||
|
||||
|
@ -97,7 +97,6 @@ class TestGlanceImageService(test.TestCase):
|
||||
|
||||
def setUp(self):
|
||||
super(TestGlanceImageService, self).setUp()
|
||||
#fakes.stub_out_compute_api_snapshot(self.stubs)
|
||||
|
||||
client = glance_stubs.StubGlanceClient()
|
||||
self.service = self._create_image_service(client)
|
||||
|
@ -718,7 +718,6 @@ class BackupCephTestCase(test.TestCase):
|
||||
self.service.delete(self.backup)
|
||||
self.assertTrue(mock_del_backup_snap.called)
|
||||
|
||||
#self.assertFalse(self.mock_rbd.ImageNotFound.called)
|
||||
self.assertTrue(self.mock_rbd.RBD.return_value.list.called)
|
||||
self.assertTrue(self.mock_rbd.RBD.return_value.remove.called)
|
||||
|
||||
|
@ -835,7 +835,6 @@ class DellSCSanISCSIDriverTestCase(test.TestCase):
|
||||
mock_init):
|
||||
context = {}
|
||||
volume = {'id': self.VOLUME.get(u'name')}
|
||||
#self.driver.ensure_export(context, volume)
|
||||
self.assertRaises(exception.VolumeBackendAPIException,
|
||||
self.driver.ensure_export,
|
||||
context,
|
||||
|
@ -31,7 +31,6 @@ VOLUMEUUID = 'a000000000000000000000000000001'
|
||||
INITIATOR = 'iqn.2013-08.org.debian:01:aaaaaaaa'
|
||||
DATA_IN_VOLUME = {'id': VOLUMEUUID}
|
||||
DATA_IN_CONNECTOR = {'initiator': INITIATOR}
|
||||
## dpl.getpool
|
||||
DATA_SERVER_INFO = 0, {
|
||||
'metadata': {'vendor': 'ProphetStor',
|
||||
'version': '1.5'}}
|
||||
@ -67,7 +66,6 @@ DATA_POOLINFO = 0, {
|
||||
'objectType': 'application/cdmi-container',
|
||||
'percentComplete': 100}
|
||||
|
||||
## dpl.assignvdev
|
||||
DATA_ASSIGNVDEV = 0, {
|
||||
'children': [],
|
||||
'childrenrange': '',
|
||||
|
@ -683,7 +683,7 @@ class XIOISEDriverTestCase(object):
|
||||
raise exception.Invalid()
|
||||
|
||||
#################################
|
||||
## UNIT TESTS ##
|
||||
# UNIT TESTS #
|
||||
#################################
|
||||
def test_do_setup(self, mock_req):
|
||||
self.setup_driver()
|
||||
|
@ -444,7 +444,6 @@ class HDSNFSDriver(nfs.NfsDriver):
|
||||
nfs_info = self._get_nfs_info()
|
||||
|
||||
for share in self.shares:
|
||||
#export = share.split(':')[1]
|
||||
if share in nfs_info.keys():
|
||||
LOG.info(_LI("share: %(share)s -> %(info)s"),
|
||||
{'share': share, 'info': nfs_info[share]['path']})
|
||||
|
5
tox.ini
5
tox.ini
@ -55,9 +55,6 @@ commands = python setup.py build_sphinx
|
||||
# E251 unexpected spaces around keyword / parameter equals
|
||||
# reason: no improvement in readability
|
||||
#
|
||||
# E265 block comment should start with '# '
|
||||
# reason: no improvement in readability
|
||||
#
|
||||
# H402 one line docstring needs punctuation
|
||||
# reason: removed in hacking (https://review.openstack.org/#/c/101497/)
|
||||
#
|
||||
@ -73,7 +70,7 @@ commands = python setup.py build_sphinx
|
||||
# H302,H405
|
||||
|
||||
|
||||
ignore = E251,E265,H302,H402,H405,H803,H904
|
||||
ignore = E251,H302,H402,H405,H803,H904
|
||||
exclude = .git,.venv,.tox,dist,tools,doc,common,*egg,build
|
||||
max-complexity=30
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user