openstack/cinder
Code Issues Proposed changes

Fix typo in delete snapshot in Synology driver

Browse Source 
Typo in delete_snapshot of Synology DSM driver. It does not cause any
failure while deleting snapshot, just log wrong information in DSM.

Change-Id: Id0c20baf496b36423cbe40e3228973ba426656b9
Closes-Bug: 1603042
This commit is contained in:
taylorh 2016-07-14 19:20:18 +08:00
parent ba1abc9275
commit a05214225f
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/tests/unit/test_synology_common.py
View File

@ -1426,7 +1426,7 @@ class SynoCommonTestCase(test.TestCase):
'delete_snapshot', 'delete_snapshot',
mock.ANY, mock.ANY,
snapshot_uuid=DS_SNAPSHOT_UUID, snapshot_uuid=DS_SNAPSHOT_UUID,
delete_by='Cinder')) deleted_by='Cinder'))
self.assertIsNone(result) self.assertIsNone(result)
result = self.common.delete_snapshot(SNAPSHOT) result = self.common.delete_snapshot(SNAPSHOT)

2
cinder/volume/drivers/synology/synology_common.py
View File

@ -1116,7 +1116,7 @@ class SynoCommon(object):
'delete_snapshot', 'delete_snapshot',
1, 1,
snapshot_uuid=ds_snapshot_uuid, snapshot_uuid=ds_snapshot_uuid,
delete_by='Cinder') deleted_by='Cinder')
self.check_response(out, snapshot_id=snapshot['id']) self.check_response(out, snapshot_id=snapshot['id'])