openstack/cinder
Code Issues Proposed changes

Port IBM flashsystem to Python 3

Browse Source 
* Replace dict.keys()[0] with list(dict.keys())[0]. On Python 3,
  dict.keys() now returns a view which is not indexable.
* tests-py3.txt: add cinder.tests.unit.test_ibm_flashsystem

Partial-Implements: blueprint cinder-python3
Change-Id: Ic77145784acc8c88e77d50a5086019e69d15e6ff
This commit is contained in:
Victor Stinner 2015-10-07 18:02:43 +02:00
parent 8c455a9f1e
commit c54e225a2a
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/volume/drivers/ibm/flashsystem_common.py
View File

@ -819,7 +819,7 @@ class FlashSystemDriver(san.SanDriver):
{'vdisk_name': vdisk_name}) {'vdisk_name': vdisk_name})
return return
else: else:
host_name = mapping_data.keys()[0] host_name = list(mapping_data.keys())[0]
else: else:
if host_name not in mapping_data: if host_name not in mapping_data:
LOG.error(_LE('_unmap_vdisk_from_host: No mapping of volume ' LOG.error(_LE('_unmap_vdisk_from_host: No mapping of volume '

1
tests-py3.txt
View File

@ -52,6 +52,7 @@ cinder.tests.unit.test_hp_xp_fc
cinder.tests.unit.test_hplefthand cinder.tests.unit.test_hplefthand
cinder.tests.unit.test_huawei_drivers cinder.tests.unit.test_huawei_drivers
cinder.tests.unit.test_huawei_drivers_compatibility cinder.tests.unit.test_huawei_drivers_compatibility
cinder.tests.unit.test_ibm_flashsystem
cinder.tests.unit.test_ibm_flashsystem_iscsi cinder.tests.unit.test_ibm_flashsystem_iscsi
cinder.tests.unit.test_ibm_xiv_ds8k cinder.tests.unit.test_ibm_xiv_ds8k
cinder.tests.unit.test_ibmnas cinder.tests.unit.test_ibmnas