diff --git a/cinder/tests/unit/objects/test_base.py b/cinder/tests/unit/objects/test_base.py index 191834c33fd..993983081f3 100644 --- a/cinder/tests/unit/objects/test_base.py +++ b/cinder/tests/unit/objects/test_base.py @@ -698,7 +698,7 @@ class TestCinderObjectConditionalUpdate(test.TestCase): # is not relevant). self.assertEqual(1, update.call_count) arg = update.call_args[0][0] - self.assertTrue(isinstance(arg, dict)) + self.assertIsInstance(arg, dict) self.assertEqual(set(values.keys()), set(arg.keys())) def test_conditional_update_multitable_fail(self): diff --git a/cinder/tests/unit/test_ssh_utils.py b/cinder/tests/unit/test_ssh_utils.py index 155b8934a36..88ade3b2ac8 100644 --- a/cinder/tests/unit/test_ssh_utils.py +++ b/cinder/tests/unit/test_ssh_utils.py @@ -302,8 +302,8 @@ class SSHPoolTestCase(test.TestCase): max_size=1) with sshpool.item() as ssh: - self.assertTrue(isinstance(ssh.get_policy(), - paramiko.RejectPolicy)) + self.assertIsInstance(ssh.get_policy(), + paramiko.RejectPolicy) @mock.patch('six.moves.builtins.open') @mock.patch('paramiko.SSHClient') @@ -322,5 +322,5 @@ class SSHPoolTestCase(test.TestCase): max_size=1) with sshpool.item() as ssh: - self.assertTrue(isinstance(ssh.get_policy(), - paramiko.AutoAddPolicy)) + self.assertIsInstance(ssh.get_policy(), + paramiko.AutoAddPolicy) diff --git a/cinder/tests/unit/volume/drivers/emc/vnx/test_taskflows.py b/cinder/tests/unit/volume/drivers/emc/vnx/test_taskflows.py index 74cd18f26c6..9fa244687c3 100644 --- a/cinder/tests/unit/volume/drivers/emc/vnx/test_taskflows.py +++ b/cinder/tests/unit/volume/drivers/emc/vnx/test_taskflows.py @@ -165,7 +165,7 @@ class TestTaskflow(test.TestCase): store=store_spec) engine.run() snap_name = engine.storage.fetch('new_cg_snap_name') - self.assertTrue(isinstance(snap_name, res_mock.StorageObjectMock)) + self.assertIsInstance(snap_name, res_mock.StorageObjectMock) @res_mock.patch_client def test_create_cg_snapshot_task_revert(self, client, mocked):