openstack/cinder
Code Issues Proposed changes

RBD: Correct DEBUG logging in QoS

Browse Source 
When logging the QoS spec, we were logging the module name and
not the actual QoS.
Also we had a space missing in another DEBUG log which this patch
addresses.

BEFORE:

Mar 07 15:34:46 Ubuntu cinder-volume[1067754]: WARNING cinder.volume.drivers.rbd [None req-34eb7e20-d3a2-4051-82da-3ea44016bf33 admin None] qos_specs: the requested qos keynon-existent-qos does not exist

Mar 07 15:39:57 Ubuntu cinder-volume[1067754]: DEBUG cinder.volume.drivers.rbd [None req-b036f742-2b79-4fbd-b490-24c2dd1f5c91 admin None] qos_specs: <module 'cinder.volume.qos_specs' from '/opt/stack/cinder/cinder/volume/qos_specs.py'> {{(pid=1067754) _qos_specs_from_volume_type /opt/stack/cinder/cinder/volume/drivers/rbd.py:1035}}

AFTER

Mar 07 15:42:04 Ubuntu cinder-volume[1070855]: WARNING cinder.volume.drivers.rbd [None req-6d26ef8a-c201-497d-9620-69d34f44e512 admin None] qos_specs: the requested qos key non-existent-qos does not exist

Mar 07 15:42:04 Ubuntu cinder-volume[1070855]: DEBUG cinder.volume.drivers.rbd [None req-6d26ef8a-c201-497d-9620-69d34f44e512 admin None] qos_specs: QualityOfServiceSpecs(consumer='back-end',created_at=2025-03-07T09:57:10Z,deleted=None,deleted_at=None,id=ca641835-3717-44ce-9f0c-1167d6f6e3b2,name='high-iops',specs={non-existent-qos='10000',total_iops_sec='10000'},updated_at=None,volume_types=<?>) {{(pid=1070855) _qos_specs_from_volume_type /opt/stack/cinder/cinder/volume/drivers/rbd.py:1035}}

Change-Id: Ia99440838ae4853054888e08042eed627ec50eb7
This commit is contained in:
Rajat Dhasmana 2025-03-07 15:43:10 +05:30
parent bded1ba83f
commit d219dffc84
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/volume/drivers/rbd.py
View File

@ -1032,7 +1032,7 @@ class RBDDriver(driver.CloneableImageVD, driver.MigrateVD,
if qos_specs_id is not None:
ctxt = context.get_admin_context()
vol_qos_specs = qos_specs.get_qos_specs(ctxt, qos_specs_id)
LOG.debug('qos_specs: %s', qos_specs)
LOG.debug('qos_specs: %s', vol_qos_specs)
if vol_qos_specs['consumer'] in ('back-end', 'both'):
return vol_qos_specs['specs']
return None
@ -2556,7 +2556,7 @@ class RBDDriver(driver.CloneableImageVD, driver.MigrateVD,
' %(qos_value)s', {'qos_key': qos_key,
'qos_value': qos_val})
else:
LOG.warning('qos_specs: the requested qos key'
LOG.warning('qos_specs: the requested qos key '
'%(qos_key)s does not exist',
{'qos_key': qos_key,
'qos_value': qos_val})