openstack/cinder
Code Issues Proposed changes

Fixes hpelefthandclient AttributeError

Browse Source 
Adds check during setup in hpe_lefthand_iscsi.py to see if
python-lefthandclient is installed.

Change-Id: Ia2dce33e0f72132167edeccdefa46d253f40c2cd
Closes-Bug: #1525321
This commit is contained in:
Samantha Blanco 2016-11-04 14:18:59 -04:00
parent 366acd02b4
commit d3ffcd5008
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cinder/volume/drivers/hpe/hpe_lefthand_iscsi.py
View File

@ -329,6 +329,14 @@ class HPELeftHandISCSIDriver(driver.ISCSIDriver):
def do_setup(self, context):
"""Set up LeftHand client."""
if not hpelefthandclient:
# Checks if client was successfully imported
ex_msg = (_("HPELeftHand client is not installed. Please"
" install using 'pip install "
"python-lefthandclient'."))
LOG.error(ex_msg)
raise exception.VolumeDriverException(ex_msg)
if hpelefthandclient.version < MIN_CLIENT_VERSION:
ex_msg = (_("Invalid hpelefthandclient version found ("
"%(found)s). Version %(minimum)s or greater "