openstack/cinder
Code Issues Proposed changes

Port image_utils to Python 3

Browse Source 
Port cinder.image_utils.check_qemu_img_version() to Python 3.

Add the following tests to Python 3.4 in tox.ini:

* cinder.tests.unit.test_image_utils
* cinder.tests.unit.test_migrations
* cinder.tests.unit.test_misc
* cinder.tests.unit.test_service

Partially implements: blueprint cinder-python3
Change-Id: I69feda94c90206adc8771fbd5ddc6aae5bb6b64b
This commit is contained in:
Victor Stinner 2015-08-17 10:25:27 -07:00
parent 9ba2d75a5a
commit d95bd7c376
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cinder/image/image_utils.py
View File

@ -80,7 +80,8 @@ def _get_version_from_string(version_string):
def check_qemu_img_version(minimum_version):
qemu_version = get_qemu_img_version()
if qemu_version < _get_version_from_string(minimum_version):
if (qemu_version is None
or qemu_version < _get_version_from_string(minimum_version)):
if qemu_version:
current_version = '.'.join((str(element)
for element in qemu_version))

4
tox.ini
View File

@ -74,7 +74,10 @@ commands =
cinder.tests.unit.test_ibm_flashsystem_iscsi \
cinder.tests.unit.test_ibmnas \
cinder.tests.unit.test_ibm_xiv_ds8k \
cinder.tests.unit.test_image_utils \
cinder.tests.unit.test_infortrend_cli \
cinder.tests.unit.test_migrations \
cinder.tests.unit.test_misc \
cinder.tests.unit.test_netapp_nfs \
cinder.tests.unit.test_nfs \
cinder.tests.unit.test_nimble \
@ -85,6 +88,7 @@ commands =
cinder.tests.unit.test_replication \
cinder.tests.unit.test_san \
cinder.tests.unit.test_scality \
cinder.tests.unit.test_service \
cinder.tests.unit.test_sheepdog \
cinder.tests.unit.test_smbfs \
cinder.tests.unit.test_solidfire \