openstack/cinder
Code Issues Proposed changes

Remove old oslo.messaging transport aliases

Browse Source 
Those are remnants from the oslo-incubator times. Also, oslo.messaging
deprecated [1] transport aliases since 5.2.0+ that is the minimal
version supported for stable/newton. The patch that bumped the minimal
version for Cinder landed 3 months+ ago, so we can proceed ripping
those aliases from the code base.

[1] I314cefa5fb1803fa7e21e3e34300e5ced31bba89

Closes-Bug: #1424728
Change-Id: Ibaab1c9132bea25abdf6dfbad2550ba572d5cf1d
This commit is contained in:
ChangBo Guo(gcb) 2017-03-19 20:51:44 +08:00
parent 3a6c184d52
commit f8c875cda0
1 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
cinder/rpc.py
View File

@ -23,7 +23,6 @@ __all__ = [
'get_client', 'get_client',
'get_server', 'get_server',
'get_notifier', 'get_notifier',
'TRANSPORT_ALIASES',
] ]
from oslo_config import cfg from oslo_config import cfg
@ -51,29 +50,15 @@ ALLOWED_EXMODS = [
] ]
EXTRA_EXMODS = [] EXTRA_EXMODS = []
# NOTE(flaper87): The cinder.openstack.common.rpc entries are
# for backwards compat with Havana rpc_backend configuration
# values. The cinder.rpc entries are for compat with Folsom values.
TRANSPORT_ALIASES = {
'cinder.openstack.common.rpc.impl_kombu': 'rabbit',
'cinder.openstack.common.rpc.impl_qpid': 'qpid',
'cinder.openstack.common.rpc.impl_zmq': 'zmq',
'cinder.rpc.impl_kombu': 'rabbit',
'cinder.rpc.impl_qpid': 'qpid',
'cinder.rpc.impl_zmq': 'zmq',
}
def init(conf): def init(conf):
global TRANSPORT, NOTIFICATION_TRANSPORT, NOTIFIER global TRANSPORT, NOTIFICATION_TRANSPORT, NOTIFIER
exmods = get_allowed_exmods() exmods = get_allowed_exmods()
TRANSPORT = messaging.get_transport(conf, TRANSPORT = messaging.get_transport(conf,
allowed_remote_exmods=exmods, allowed_remote_exmods=exmods)
aliases=TRANSPORT_ALIASES)
NOTIFICATION_TRANSPORT = messaging.get_notification_transport( NOTIFICATION_TRANSPORT = messaging.get_notification_transport(
conf, conf,
allowed_remote_exmods=exmods, allowed_remote_exmods=exmods)
aliases=TRANSPORT_ALIASES)
# get_notification_transport has loaded oslo_messaging_notifications config # get_notification_transport has loaded oslo_messaging_notifications config
# group, so we can now check if notifications are actually enabled. # group, so we can now check if notifications are actually enabled.