openstack/cinder
Code Issues Proposed changes

Mock out time.sleep in storwize unit tests

Browse Source 
The Storwize driver has issues that required them
to add a sleep 1 on init of the driver.

No big deal, but causes unit tests to take a very long
time waiting for the "time.sleep(1)" on every single
unit test that calls init.

This patch just mocks out the time.sleep so we don't have
to do the silly waiting in unit tests.

Change-Id: I10fc3d00252a7e7b90085cb308fb9c6c7e1f5ea7
This commit is contained in:
John Griffith 2014-07-14 17:10:18 -06:00
parent cfe8f2dec1
commit f9ae768811
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/tests/test_storwize_svc.py
View File

@ -21,6 +21,7 @@ Tests for the IBM Storwize family and SVC volume driver.
import mock
import random
import re
import time
from cinder import context
from cinder import exception
@ -1455,7 +1456,8 @@ class StorwizeSVCFakeDriver(storwize_svc.StorwizeSVCDriver):
class StorwizeSVCDriverTestCase(test.TestCase):
def setUp(self):
@mock.patch.object(time, 'sleep')
def setUp(self, mock_sleep):
super(StorwizeSVCDriverTestCase, self).setUp()
self.USESIM = True
if self.USESIM: