3d301346a7
There was a bug in WSGIService in the way that it was checking the osapi_volume_workers option. It was using getattr() to see if the option was set, if not it was supposed to set the value to processutils.get_worker_count(). This, however, never happened because getattr interpreted the default 'None' value to be a value. So, on any system with no value set the self.workers < 1 check would be hit and a warning would be output. Nova had changed their approach to this option to avoid this problem. This patch pulls Nova's approach into Cinder for consistency. Cinder will now use processutils.get_worker_count() if no option is set in /etc/cinder/cinder.conf and when the user sets osapi_volume_workers to 0. A negative value will cause an InvalidInput exception to be thrown. Unittests have been added for this functionality. Change-Id: I4ec2fdd0d19195cccffd63cdd1af1b9ca9884c7d Closes-bug: #1367454
The Choose Your Own Adventure README for Cinder
You have come across a storage service for an open cloud computing service. It has identified itself as "Cinder." It was abstracted from the Nova project.
To monitor it from a distance: follow @openstack on twitter.
To tame it for use in your own cloud: read http://docs.openstack.org
To study its anatomy: read http://cinder.openstack.org
To dissect it in detail: visit http://github.com/openstack/cinder
To taunt it with its weaknesses: use http://bugs.launchpad.net/cinder
To watch it: http://jenkins.openstack.org
To hack at it: read HACKING.rst