b2050e4a08
* Replace xrange() with six.moves.range() * Replace filter() with list-comprehension to get a list on Python 3. * get_formatted_wwn(): join byte strings with b':' instead of ':' * ZoneManager: don't pass arguments to object.__new__() * tests-py3.txt: add zonemanager tests Partial-Implements: blueprint cinder-python3 Change-Id: Ia3fcd816c5afd7a08b8769fbc9d2839b70c8c3fb
424 lines
18 KiB
Python
424 lines
18 KiB
Python
# (c) Copyright 2015 Brocade Communications Systems Inc.
|
|
# All Rights Reserved.
|
|
#
|
|
# Copyright 2015 OpenStack Foundation
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
|
|
"""
|
|
Brocade Zone Driver is responsible to manage access control using FC zoning
|
|
for Brocade FC fabrics.
|
|
This is a concrete implementation of FCZoneDriver interface implementing
|
|
add_connection and delete_connection interfaces.
|
|
|
|
**Related Flags**
|
|
|
|
:zone_activate: Used by: class: 'FCZoneDriver'. Defaults to True
|
|
:zone_name_prefix: Used by: class: 'FCZoneDriver'. Defaults to 'openstack'
|
|
"""
|
|
|
|
|
|
from oslo_concurrency import lockutils
|
|
from oslo_config import cfg
|
|
from oslo_log import log as logging
|
|
from oslo_utils import excutils
|
|
from oslo_utils import importutils
|
|
import six
|
|
|
|
from cinder import exception
|
|
from cinder.i18n import _, _LE, _LI
|
|
from cinder.zonemanager.drivers.brocade import brcd_fabric_opts as fabric_opts
|
|
from cinder.zonemanager.drivers import fc_zone_driver
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
brcd_opts = [
|
|
cfg.StrOpt('brcd_sb_connector',
|
|
default='cinder.zonemanager.drivers.brocade'
|
|
'.brcd_fc_zone_client_cli.BrcdFCZoneClientCLI',
|
|
help='Southbound connector for zoning operation'),
|
|
]
|
|
|
|
CONF = cfg.CONF
|
|
CONF.register_opts(brcd_opts, group='fc-zone-manager')
|
|
|
|
|
|
class BrcdFCZoneDriver(fc_zone_driver.FCZoneDriver):
|
|
"""Brocade FC zone driver implementation.
|
|
|
|
OpenStack Fibre Channel zone driver to manage FC zoning in
|
|
Brocade SAN fabrics.
|
|
|
|
Version history:
|
|
1.0 - Initial Brocade FC zone driver
|
|
1.1 - Implements performance enhancements
|
|
"""
|
|
|
|
VERSION = "1.1"
|
|
|
|
def __init__(self, **kwargs):
|
|
super(BrcdFCZoneDriver, self).__init__(**kwargs)
|
|
self.sb_conn_map = {}
|
|
self.configuration = kwargs.get('configuration', None)
|
|
if self.configuration:
|
|
self.configuration.append_config_values(brcd_opts)
|
|
# Adding a hack to hendle parameters from super classes
|
|
# in case configured with multi backend.
|
|
fabric_names = self.configuration.safe_get('fc_fabric_names')
|
|
base_san_opts = []
|
|
if not fabric_names:
|
|
base_san_opts.append(
|
|
cfg.StrOpt('fc_fabric_names',
|
|
help='Comma separated list of fibre channel '
|
|
'fabric names. This list of names is used to'
|
|
' retrieve other SAN credentials for connecting'
|
|
' to each SAN fabric'
|
|
))
|
|
if len(base_san_opts) > 0:
|
|
CONF.register_opts(base_san_opts)
|
|
self.configuration.append_config_values(base_san_opts)
|
|
|
|
fc_fabric_names = self.configuration.fc_fabric_names
|
|
fabric_names = [x.strip() for x in fc_fabric_names.split(',')]
|
|
|
|
# There can be more than one SAN in the network and we need to
|
|
# get credentials for each SAN.
|
|
if fabric_names:
|
|
self.fabric_configs = fabric_opts.load_fabric_configurations(
|
|
fabric_names)
|
|
|
|
def get_formatted_wwn(self, wwn_str):
|
|
"""Utility API that formats WWN to insert ':'."""
|
|
wwn_str = wwn_str.encode('ascii')
|
|
if len(wwn_str) != 16:
|
|
return wwn_str
|
|
else:
|
|
return b':'.join(
|
|
[wwn_str[i:i + 2] for i in range(0, len(wwn_str), 2)])
|
|
|
|
@lockutils.synchronized('brcd', 'fcfabric-', True)
|
|
def add_connection(self, fabric, initiator_target_map):
|
|
"""Concrete implementation of add_connection.
|
|
|
|
Based on zoning policy and state of each I-T pair, list of zone
|
|
members are created and pushed to the fabric to add zones. The
|
|
new zones created or zones updated are activated based on isActivate
|
|
flag set in cinder.conf returned by volume driver after attach
|
|
operation.
|
|
|
|
:param fabric: Fabric name from cinder.conf file
|
|
:param initiator_target_map: Mapping of initiator to list of targets
|
|
"""
|
|
LOG.debug("Add connection for Fabric: %s", fabric)
|
|
LOG.info(_LI("BrcdFCZoneDriver - Add connection "
|
|
"for I-T map: %s"), initiator_target_map)
|
|
zoning_policy = self.configuration.zoning_policy
|
|
zoning_policy_fab = self.fabric_configs[fabric].safe_get(
|
|
'zoning_policy')
|
|
if zoning_policy_fab:
|
|
zoning_policy = zoning_policy_fab
|
|
zone_name_prefix = self.fabric_configs[fabric].safe_get(
|
|
'zone_name_prefix')
|
|
if not zone_name_prefix:
|
|
zone_name_prefix = 'openstack'
|
|
zone_activate = self.fabric_configs[fabric].safe_get(
|
|
'zone_activate')
|
|
|
|
LOG.info(_LI("Zoning policy for Fabric %s"), zoning_policy)
|
|
cli_client = self._get_cli_client(fabric)
|
|
cfgmap_from_fabric = self._get_active_zone_set(cli_client)
|
|
|
|
zone_names = []
|
|
if cfgmap_from_fabric.get('zones'):
|
|
zone_names = cfgmap_from_fabric['zones'].keys()
|
|
# based on zoning policy, create zone member list and
|
|
# push changes to fabric.
|
|
for initiator_key in initiator_target_map.keys():
|
|
zone_map = {}
|
|
initiator = initiator_key.lower()
|
|
t_list = initiator_target_map[initiator_key]
|
|
if zoning_policy == 'initiator-target':
|
|
for t in t_list:
|
|
target = t.lower()
|
|
zone_members = [self.get_formatted_wwn(initiator),
|
|
self.get_formatted_wwn(target)]
|
|
zone_name = (zone_name_prefix
|
|
+ initiator.replace(':', '')
|
|
+ target.replace(':', ''))
|
|
if (
|
|
len(cfgmap_from_fabric) == 0 or (
|
|
zone_name not in zone_names)):
|
|
zone_map[zone_name] = zone_members
|
|
else:
|
|
# This is I-T zoning, skip if zone already exists.
|
|
LOG.info(_LI("Zone exists in I-T mode. "
|
|
"Skipping zone creation %s"), zone_name)
|
|
elif zoning_policy == 'initiator':
|
|
zone_members = [self.get_formatted_wwn(initiator)]
|
|
for t in t_list:
|
|
target = t.lower()
|
|
zone_members.append(self.get_formatted_wwn(target))
|
|
|
|
zone_name = zone_name_prefix + initiator.replace(':', '')
|
|
|
|
if len(zone_names) > 0 and (zone_name in zone_names):
|
|
zone_members = zone_members + filter(
|
|
lambda x: x not in zone_members,
|
|
cfgmap_from_fabric['zones'][zone_name])
|
|
|
|
zone_map[zone_name] = zone_members
|
|
else:
|
|
msg = _("Zoning Policy: %s, not "
|
|
"recognized") % zoning_policy
|
|
LOG.error(msg)
|
|
raise exception.FCZoneDriverException(msg)
|
|
|
|
LOG.info(_LI("Zone map to add: %s"), zone_map)
|
|
|
|
if len(zone_map) > 0:
|
|
try:
|
|
cli_client.add_zones(
|
|
zone_map, zone_activate,
|
|
cfgmap_from_fabric)
|
|
cli_client.cleanup()
|
|
except exception.BrocadeZoningCliException as brocade_ex:
|
|
raise exception.FCZoneDriverException(brocade_ex)
|
|
except Exception:
|
|
msg = _("Failed to add zoning configuration.")
|
|
LOG.exception(msg)
|
|
raise exception.FCZoneDriverException(msg)
|
|
LOG.debug("Zones added successfully: %s", zone_map)
|
|
|
|
@lockutils.synchronized('brcd', 'fcfabric-', True)
|
|
def delete_connection(self, fabric, initiator_target_map):
|
|
"""Concrete implementation of delete_connection.
|
|
|
|
Based on zoning policy and state of each I-T pair, list of zones
|
|
are created for deletion. The zones are either updated deleted based
|
|
on the policy and attach/detach state of each I-T pair.
|
|
|
|
:param fabric: Fabric name from cinder.conf file
|
|
:param initiator_target_map: Mapping of initiator to list of targets
|
|
"""
|
|
LOG.debug("Delete connection for fabric: %s", fabric)
|
|
LOG.info(_LI("BrcdFCZoneDriver - Delete connection for I-T map: %s"),
|
|
initiator_target_map)
|
|
zoning_policy = self.configuration.zoning_policy
|
|
zoning_policy_fab = self.fabric_configs[fabric].safe_get(
|
|
'zoning_policy')
|
|
if zoning_policy_fab:
|
|
zoning_policy = zoning_policy_fab
|
|
zone_name_prefix = self.fabric_configs[fabric].safe_get(
|
|
'zone_name_prefix')
|
|
if not zone_name_prefix:
|
|
zone_name_prefix = 'openstack'
|
|
zone_activate = self.fabric_configs[fabric].safe_get(
|
|
'zone_activate')
|
|
|
|
LOG.info(_LI("Zoning policy for fabric %s"), zoning_policy)
|
|
conn = self._get_cli_client(fabric)
|
|
cfgmap_from_fabric = self._get_active_zone_set(conn)
|
|
|
|
zone_names = []
|
|
if cfgmap_from_fabric.get('zones'):
|
|
zone_names = cfgmap_from_fabric['zones'].keys()
|
|
|
|
# Based on zoning policy, get zone member list and push changes to
|
|
# fabric. This operation could result in an update for zone config
|
|
# with new member list or deleting zones from active cfg.
|
|
LOG.debug("zone config from Fabric: %s", cfgmap_from_fabric)
|
|
for initiator_key in initiator_target_map.keys():
|
|
initiator = initiator_key.lower()
|
|
formatted_initiator = self.get_formatted_wwn(initiator)
|
|
zone_map = {}
|
|
zones_to_delete = []
|
|
t_list = initiator_target_map[initiator_key]
|
|
if zoning_policy == 'initiator-target':
|
|
# In this case, zone needs to be deleted.
|
|
for t in t_list:
|
|
target = t.lower()
|
|
zone_name = (
|
|
zone_name_prefix
|
|
+ initiator.replace(':', '')
|
|
+ target.replace(':', ''))
|
|
LOG.debug("Zone name to del: %s", zone_name)
|
|
if len(zone_names) > 0 and (zone_name in zone_names):
|
|
# delete zone.
|
|
LOG.debug("Added zone to delete to "
|
|
"list: %s", zone_name)
|
|
zones_to_delete.append(zone_name)
|
|
|
|
elif zoning_policy == 'initiator':
|
|
zone_members = [formatted_initiator]
|
|
for t in t_list:
|
|
target = t.lower()
|
|
zone_members.append(self.get_formatted_wwn(target))
|
|
|
|
zone_name = zone_name_prefix + initiator.replace(':', '')
|
|
|
|
if (zone_names and (zone_name in zone_names)):
|
|
filtered_members = filter(
|
|
lambda x: x not in zone_members,
|
|
cfgmap_from_fabric['zones'][zone_name])
|
|
|
|
# The assumption here is that initiator is always there
|
|
# in the zone as it is 'initiator' policy. We find the
|
|
# filtered list and if it is non-empty, add initiator
|
|
# to it and update zone if filtered list is empty, we
|
|
# remove that zone.
|
|
LOG.debug("Zone delete - I mode: "
|
|
"filtered targets: %s", filtered_members)
|
|
if filtered_members:
|
|
filtered_members.append(formatted_initiator)
|
|
LOG.debug("Filtered zone members to "
|
|
"update: %s", filtered_members)
|
|
zone_map[zone_name] = filtered_members
|
|
LOG.debug("Filtered zone Map to "
|
|
"update: %s", zone_map)
|
|
else:
|
|
zones_to_delete.append(zone_name)
|
|
else:
|
|
LOG.info(_LI("Zoning Policy: %s, not "
|
|
"recognized"), zoning_policy)
|
|
LOG.debug("Final Zone map to update: %s", zone_map)
|
|
LOG.debug("Final Zone list to delete: %s", zones_to_delete)
|
|
try:
|
|
# Update zone membership.
|
|
if zone_map:
|
|
conn.add_zones(
|
|
zone_map, zone_activate,
|
|
cfgmap_from_fabric)
|
|
# Delete zones ~sk.
|
|
if zones_to_delete:
|
|
zone_name_string = ''
|
|
num_zones = len(zones_to_delete)
|
|
for i in range(0, num_zones):
|
|
if i == 0:
|
|
zone_name_string = (
|
|
'%s%s' % (
|
|
zone_name_string, zones_to_delete[i]))
|
|
else:
|
|
zone_name_string = '%s;%s' % (
|
|
zone_name_string, zones_to_delete[i])
|
|
|
|
conn.delete_zones(
|
|
zone_name_string, zone_activate,
|
|
cfgmap_from_fabric)
|
|
conn.cleanup()
|
|
except Exception:
|
|
msg = _("Failed to update or delete zoning configuration")
|
|
LOG.exception(msg)
|
|
raise exception.FCZoneDriverException(msg)
|
|
|
|
def get_san_context(self, target_wwn_list):
|
|
"""Lookup SAN context for visible end devices.
|
|
|
|
Look up each SAN configured and return a map of SAN (fabric IP) to
|
|
list of target WWNs visible to the fabric.
|
|
"""
|
|
# TODO(Santhosh Kolathur): consider refactoring to use lookup service.
|
|
formatted_target_list = []
|
|
fabric_map = {}
|
|
fc_fabric_names = self.configuration.fc_fabric_names
|
|
fabrics = [x.strip() for x in fc_fabric_names.split(',')]
|
|
LOG.debug("Fabric List: %s", fabrics)
|
|
LOG.debug("Target wwn List: %s", target_wwn_list)
|
|
if len(fabrics) > 0:
|
|
for t in target_wwn_list:
|
|
formatted_target_list.append(self.get_formatted_wwn(t.lower()))
|
|
LOG.debug("Formatted Target wwn List:"
|
|
" %s", formatted_target_list)
|
|
for fabric_name in fabrics:
|
|
conn = self._get_cli_client(fabric_name)
|
|
|
|
# Get name server data from fabric and get the targets
|
|
# logged in.
|
|
nsinfo = None
|
|
try:
|
|
nsinfo = conn.get_nameserver_info()
|
|
LOG.debug("name server info from fabric: %s", nsinfo)
|
|
conn.cleanup()
|
|
except exception.BrocadeZoningCliException:
|
|
if not conn.is_supported_firmware():
|
|
msg = _("Unsupported firmware on switch %s. Make sure "
|
|
"switch is running firmware v6.4 or higher"
|
|
) % conn.switch_ip
|
|
LOG.error(msg)
|
|
raise exception.FCZoneDriverException(msg)
|
|
with excutils.save_and_reraise_exception():
|
|
LOG.exception(_LE("Error getting name server info."))
|
|
except Exception:
|
|
msg = _("Failed to get name server info.")
|
|
LOG.exception(msg)
|
|
raise exception.FCZoneDriverException(msg)
|
|
visible_targets = filter(
|
|
lambda x: x in formatted_target_list,
|
|
nsinfo)
|
|
|
|
if visible_targets:
|
|
LOG.info(_LI("Filtered targets for SAN is: %s"),
|
|
{fabric_name: visible_targets})
|
|
# getting rid of the ':' before returning
|
|
for idx, elem in enumerate(visible_targets):
|
|
visible_targets[idx] = str(
|
|
visible_targets[idx]).replace(':', '')
|
|
fabric_map[fabric_name] = visible_targets
|
|
else:
|
|
LOG.debug("No targets are in the nameserver for SAN %s",
|
|
fabric_name)
|
|
LOG.debug("Return SAN context output: %s", fabric_map)
|
|
return fabric_map
|
|
|
|
def _get_active_zone_set(self, conn):
|
|
cfgmap = None
|
|
try:
|
|
cfgmap = conn.get_active_zone_set()
|
|
except exception.BrocadeZoningCliException:
|
|
if not conn.is_supported_firmware():
|
|
msg = _("Unsupported firmware on switch %s. Make sure "
|
|
"switch is running firmware v6.4 or higher"
|
|
) % conn.switch_ip
|
|
LOG.error(msg)
|
|
raise exception.FCZoneDriverException(msg)
|
|
except Exception as e:
|
|
msg = (_("Failed to retrieve active zoning configuration %s")
|
|
% six.text_type(e))
|
|
raise exception.FCZoneDriverException(msg)
|
|
LOG.debug("Active zone set from fabric: %s", cfgmap)
|
|
return cfgmap
|
|
|
|
def _get_cli_client(self, fabric):
|
|
fabric_ip = self.fabric_configs[fabric].safe_get('fc_fabric_address')
|
|
fabric_user = self.fabric_configs[fabric].safe_get('fc_fabric_user')
|
|
fabric_pwd = self.fabric_configs[fabric].safe_get('fc_fabric_password')
|
|
fabric_port = self.fabric_configs[fabric].safe_get('fc_fabric_port')
|
|
cli_client = None
|
|
try:
|
|
cli_client = self.sb_conn_map.get(fabric_ip)
|
|
if not cli_client:
|
|
LOG.debug("CLI client not found, creating for %s", fabric_ip)
|
|
cli_client = importutils.import_object(
|
|
self.configuration.brcd_sb_connector,
|
|
ipaddress=fabric_ip,
|
|
username=fabric_user,
|
|
password=fabric_pwd,
|
|
port=fabric_port)
|
|
self.sb_conn_map[fabric_ip] = cli_client
|
|
except Exception as e:
|
|
LOG.error(e)
|
|
msg = _("Failed to create sb connector for %s") % fabric_ip
|
|
raise exception.FCZoneDriverException(msg)
|
|
return cli_client
|