708b9be9c0
This is the fifth patch that implements the generic-volume-group
bluerpint. It adds APIs for group snapshots and create group
from source.
This patch depends on the fourth patch which implements group
snapshots support in the volume manager:
https://review.openstack.org/#/c/361376/
Client side patch is here:
https://review.openstack.org/#/c/329770/
Current microversion is 3.14. The following CLI's are supported:
cinder --os-volume-api-version 3.14 group-create-from-src
--name my_group --group-snapshot <group snapshot uuid>
cinder --os-volume-api-version 3.14 group-create-from-src
--name my_group --source-group <source group uuid>
cinder --os-volume-api-version 3.14 group-snapshot-create
--name <name> <group uuid>
cinder --os-volume-api-version 3.14 group-snapshot-list
cinder --os-volume-api-version 3.14 group-snapshot-show
<group snapshot uuid>
cinder --os-volume-api-version 3.14 group-snapshot-delete
<group snapshot uuid>
APIImpact
DocImpact
Partial-Implements: blueprint generic-volume-group
Change-Id: I2e628968afcf058113e1f1aeb851570c7f0f3a08
291 lines
11 KiB
Python
291 lines
11 KiB
Python
# Copyright (c) 2016 EMC Corporation
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""The groups controller."""
|
|
|
|
from oslo_log import log as logging
|
|
from oslo_utils import strutils
|
|
import webob
|
|
from webob import exc
|
|
|
|
from cinder.api import common
|
|
from cinder.api.openstack import wsgi
|
|
from cinder.api.v3.views import groups as views_groups
|
|
from cinder import exception
|
|
from cinder import group as group_api
|
|
from cinder.i18n import _, _LI
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
GROUP_API_VERSION = '3.13'
|
|
GROUP_CREATE_FROM_SRC_API_VERSION = '3.14'
|
|
|
|
|
|
class GroupsController(wsgi.Controller):
|
|
"""The groups API controller for the OpenStack API."""
|
|
|
|
_view_builder_class = views_groups.ViewBuilder
|
|
|
|
def __init__(self):
|
|
self.group_api = group_api.API()
|
|
super(GroupsController, self).__init__()
|
|
|
|
@wsgi.Controller.api_version(GROUP_API_VERSION)
|
|
def show(self, req, id):
|
|
"""Return data about the given group."""
|
|
LOG.debug('show called for member %s', id)
|
|
context = req.environ['cinder.context']
|
|
|
|
# Not found exception will be handled at the wsgi level
|
|
group = self.group_api.get(
|
|
context,
|
|
group_id=id)
|
|
|
|
return self._view_builder.detail(req, group)
|
|
|
|
@wsgi.Controller.api_version(GROUP_API_VERSION)
|
|
@wsgi.action("delete")
|
|
def delete_group(self, req, id, body):
|
|
return self._delete(req, id, body)
|
|
|
|
def _delete(self, req, id, body):
|
|
"""Delete a group."""
|
|
LOG.debug('delete called for group %s', id)
|
|
context = req.environ['cinder.context']
|
|
del_vol = False
|
|
if body:
|
|
if not self.is_valid_body(body, 'delete'):
|
|
msg = _("Missing required element 'delete' in "
|
|
"request body.")
|
|
raise exc.HTTPBadRequest(explanation=msg)
|
|
|
|
grp_body = body['delete']
|
|
try:
|
|
del_vol = strutils.bool_from_string(
|
|
grp_body.get('delete-volumes', False),
|
|
strict=True)
|
|
except ValueError:
|
|
msg = (_("Invalid value '%s' for delete-volumes flag.")
|
|
% del_vol)
|
|
raise exc.HTTPBadRequest(explanation=msg)
|
|
|
|
LOG.info(_LI('Delete group with id: %s'), id,
|
|
context=context)
|
|
|
|
try:
|
|
group = self.group_api.get(context, id)
|
|
self.group_api.delete(context, group, del_vol)
|
|
except exception.GroupNotFound:
|
|
# Not found exception will be handled at the wsgi level
|
|
raise
|
|
except exception.InvalidGroup as error:
|
|
raise exc.HTTPBadRequest(explanation=error.msg)
|
|
|
|
return webob.Response(status_int=202)
|
|
|
|
@wsgi.Controller.api_version(GROUP_API_VERSION)
|
|
def index(self, req):
|
|
"""Returns a summary list of groups."""
|
|
return self._get_groups(req, is_detail=False)
|
|
|
|
@wsgi.Controller.api_version(GROUP_API_VERSION)
|
|
def detail(self, req):
|
|
"""Returns a detailed list of groups."""
|
|
return self._get_groups(req, is_detail=True)
|
|
|
|
def _get_groups(self, req, is_detail):
|
|
"""Returns a list of groups through view builder."""
|
|
context = req.environ['cinder.context']
|
|
filters = req.params.copy()
|
|
marker, limit, offset = common.get_pagination_params(filters)
|
|
sort_keys, sort_dirs = common.get_sort_params(filters)
|
|
|
|
groups = self.group_api.get_all(
|
|
context, filters=filters, marker=marker, limit=limit,
|
|
offset=offset, sort_keys=sort_keys, sort_dirs=sort_dirs)
|
|
|
|
if is_detail:
|
|
groups = self._view_builder.detail_list(
|
|
req, groups)
|
|
else:
|
|
groups = self._view_builder.summary_list(
|
|
req, groups)
|
|
return groups
|
|
|
|
@wsgi.Controller.api_version(GROUP_API_VERSION)
|
|
@wsgi.response(202)
|
|
def create(self, req, body):
|
|
"""Create a new group."""
|
|
LOG.debug('Creating new group %s', body)
|
|
self.assert_valid_body(body, 'group')
|
|
|
|
context = req.environ['cinder.context']
|
|
group = body['group']
|
|
self.validate_name_and_description(group)
|
|
name = group.get('name')
|
|
description = group.get('description')
|
|
group_type = group.get('group_type')
|
|
if not group_type:
|
|
msg = _("group_type must be provided to create "
|
|
"group %(name)s.") % {'name': name}
|
|
raise exc.HTTPBadRequest(explanation=msg)
|
|
volume_types = group.get('volume_types')
|
|
if not volume_types:
|
|
msg = _("volume_types must be provided to create "
|
|
"group %(name)s.") % {'name': name}
|
|
raise exc.HTTPBadRequest(explanation=msg)
|
|
availability_zone = group.get('availability_zone')
|
|
|
|
LOG.info(_LI("Creating group %(name)s."),
|
|
{'name': name},
|
|
context=context)
|
|
|
|
try:
|
|
new_group = self.group_api.create(
|
|
context, name, description, group_type, volume_types,
|
|
availability_zone=availability_zone)
|
|
except (exception.Invalid, exception.ObjectActionError) as error:
|
|
raise exc.HTTPBadRequest(explanation=error.msg)
|
|
except exception.NotFound:
|
|
# Not found exception will be handled at the wsgi level
|
|
raise
|
|
|
|
retval = self._view_builder.summary(req, new_group)
|
|
return retval
|
|
|
|
@wsgi.Controller.api_version(GROUP_CREATE_FROM_SRC_API_VERSION)
|
|
@wsgi.action("create-from-src")
|
|
@wsgi.response(202)
|
|
def create_from_src(self, req, body):
|
|
"""Create a new group from a source.
|
|
|
|
The source can be a group snapshot or a group. Note that
|
|
this does not require group_type and volume_types as the
|
|
"create" API above.
|
|
"""
|
|
LOG.debug('Creating new group %s.', body)
|
|
self.assert_valid_body(body, 'create-from-src')
|
|
|
|
context = req.environ['cinder.context']
|
|
group = body['create-from-src']
|
|
self.validate_name_and_description(group)
|
|
name = group.get('name', None)
|
|
description = group.get('description', None)
|
|
group_snapshot_id = group.get('group_snapshot_id', None)
|
|
source_group_id = group.get('source_group_id', None)
|
|
if not group_snapshot_id and not source_group_id:
|
|
msg = (_("Either 'group_snapshot_id' or 'source_group_id' must be "
|
|
"provided to create group %(name)s from source.")
|
|
% {'name': name})
|
|
raise exc.HTTPBadRequest(explanation=msg)
|
|
|
|
if group_snapshot_id and source_group_id:
|
|
msg = _("Cannot provide both 'group_snapshot_id' and "
|
|
"'source_group_id' to create group %(name)s from "
|
|
"source.") % {'name': name}
|
|
raise exc.HTTPBadRequest(explanation=msg)
|
|
|
|
if group_snapshot_id:
|
|
LOG.info(_LI("Creating group %(name)s from group_snapshot "
|
|
"%(snap)s."),
|
|
{'name': name, 'snap': group_snapshot_id},
|
|
context=context)
|
|
elif source_group_id:
|
|
LOG.info(_LI("Creating group %(name)s from "
|
|
"source group %(source_group_id)s."),
|
|
{'name': name, 'source_group_id': source_group_id},
|
|
context=context)
|
|
|
|
try:
|
|
new_group = self.group_api.create_from_src(
|
|
context, name, description, group_snapshot_id, source_group_id)
|
|
except exception.InvalidGroup as error:
|
|
raise exc.HTTPBadRequest(explanation=error.msg)
|
|
except (exception.GroupNotFound, exception.GroupSnapshotNotFound):
|
|
# Not found exception will be handled at the wsgi level
|
|
raise
|
|
except exception.CinderException as error:
|
|
raise exc.HTTPBadRequest(explanation=error.msg)
|
|
|
|
retval = self._view_builder.summary(req, new_group)
|
|
return retval
|
|
|
|
@wsgi.Controller.api_version(GROUP_API_VERSION)
|
|
def update(self, req, id, body):
|
|
"""Update the group.
|
|
|
|
Expected format of the input parameter 'body':
|
|
|
|
.. code-block:: json
|
|
|
|
{
|
|
"group":
|
|
{
|
|
"name": "my_group",
|
|
"description": "My group",
|
|
"add_volumes": "volume-uuid-1,volume-uuid-2,...",
|
|
"remove_volumes": "volume-uuid-8,volume-uuid-9,..."
|
|
}
|
|
}
|
|
|
|
"""
|
|
LOG.debug('Update called for group %s.', id)
|
|
|
|
if not body:
|
|
msg = _("Missing request body.")
|
|
raise exc.HTTPBadRequest(explanation=msg)
|
|
|
|
self.assert_valid_body(body, 'group')
|
|
context = req.environ['cinder.context']
|
|
|
|
group = body.get('group')
|
|
self.validate_name_and_description(group)
|
|
name = group.get('name')
|
|
description = group.get('description')
|
|
add_volumes = group.get('add_volumes')
|
|
remove_volumes = group.get('remove_volumes')
|
|
|
|
# Allow name or description to be changed to an empty string ''.
|
|
if (name is None and description is None and not add_volumes
|
|
and not remove_volumes):
|
|
msg = _("Name, description, add_volumes, and remove_volumes "
|
|
"can not be all empty in the request body.")
|
|
raise exc.HTTPBadRequest(explanation=msg)
|
|
|
|
LOG.info(_LI("Updating group %(id)s with name %(name)s "
|
|
"description: %(description)s add_volumes: "
|
|
"%(add_volumes)s remove_volumes: %(remove_volumes)s."),
|
|
{'id': id, 'name': name,
|
|
'description': description,
|
|
'add_volumes': add_volumes,
|
|
'remove_volumes': remove_volumes},
|
|
context=context)
|
|
|
|
try:
|
|
group = self.group_api.get(context, id)
|
|
self.group_api.update(
|
|
context, group, name, description,
|
|
add_volumes, remove_volumes)
|
|
except exception.GroupNotFound:
|
|
# Not found exception will be handled at the wsgi level
|
|
raise
|
|
except exception.InvalidGroup as error:
|
|
raise exc.HTTPBadRequest(explanation=error.msg)
|
|
|
|
return webob.Response(status_int=202)
|
|
|
|
|
|
def create_resource():
|
|
return wsgi.Resource(GroupsController())
|