openstack/devstack-plugin-kafka
Code Issues Proposed changes

Don't install kafka-python

Browse Source 
This should have been removed when we switched oslo.messaging to
confluent-kafka way back in the victoria cycle [1].

We also update tox to update whitelist_externals to allowlist_externals.

[1] Idfb9fe3700d882c8285c6dc56b0620951178eba2

Change-Id: I3d87e4bb5775aa549ccf3c8266c4161c2dc4a110
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane 2024-04-17 11:23:02 +01:00
parent 4e1c82f637
commit c6662b06a2
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
devstack/plugin.sh
View File

@ -89,8 +89,6 @@ function _download_kafka {
# driver # driver
function _install_kafka_python { function _install_kafka_python {
# Install kafka client API # Install kafka client API
# TODO(ansmith) remove kafka-python library following switch
pip_install_gr kafka-python
pip_install_gr confluent-kafka pip_install_gr confluent-kafka
} }

3
tox.ini
View File

@ -8,9 +8,8 @@ usedevelop = False
install_command = pip install {opts} {packages} install_command = pip install {opts} {packages}
[testenv:bashate] [testenv:bashate]
basepython = python3
deps = bashate deps = bashate
whitelist_externals = bash allowlist_externals = bash
commands = bash -c "find {toxinidir} \ commands = bash -c "find {toxinidir} \
-not \( -type d -name .?\* -prune \) \ -not \( -type d -name .?\* -prune \) \
-not \( -type d -name doc -prune \) \ -not \( -type d -name doc -prune \) \