openstack/kolla-ansible
Code Issues Proposed changes
6c72fa8117
kolla-ansible/ansible/roles/haproxy/tasks/deploy.yml

12 lines
344 B
YAML
Raw Normal View History

Allow haproxy role to pull images Change-Id: I094f1d35f60bf566ba7382504a7425f16ae975d8 Partially-Implements: blueprint pre-pull-images
2016-01-05 17:52:38 +00:00
---
Performance: replace unconditional include_tasks with import_tasks Including tasks has a performance penalty when compared with importing tasks. If the include has a condition associated with it, then the overhead of the include may be lower than the overhead of skipping all imported tasks. For unconditionally included tasks, switching to import_tasks provides a clear benefit. Benchmarking of include vs. import is available at [1]. This change switches from include_tasks to import_tasks where there is no condition applied to the include. [1] https://github.com/stackhpc/ansible-scaling/blob/master/doc/include-and-import.md#task-include-and-import Partially-Implements: blueprint performance-improvements Change-Id: Ia45af4a198e422773d9f009c7f7b2e32ce9e3b97
2020-06-29 15:06:53 +01:00
- import_tasks: config-host.yml
Separate per-service host configuration tasks Currently there are a few services that perform host configuration tasks. This is done in config.yml. This means that these changes are performed during 'kolla-ansible genconfig', when we might expect not to be making any changes to the remote system. This change separates out these host configuration tasks into a config-host.yml file, which is included directly from deploy.yml. One change in behaviour is that this prevents these tasks from running during an upgrade or genconfig. This is probably what we want, but we should be careful when any of these host configuration tasks are changed, to ensure they are applied during an upgrade if necessary. Change-Id: I001defc75d1f1e6caa9b1e11246abc6ce17c775b Closes-Bug: #1860161
2020-01-17 17:00:21 +00:00
Performance: replace unconditional include_tasks with import_tasks Including tasks has a performance penalty when compared with importing tasks. If the include has a condition associated with it, then the overhead of the include may be lower than the overhead of skipping all imported tasks. For unconditionally included tasks, switching to import_tasks provides a clear benefit. Benchmarking of include vs. import is available at [1]. This change switches from include_tasks to import_tasks where there is no condition applied to the include. [1] https://github.com/stackhpc/ansible-scaling/blob/master/doc/include-and-import.md#task-include-and-import Partially-Implements: blueprint performance-improvements Change-Id: Ia45af4a198e422773d9f009c7f7b2e32ce9e3b97
2020-06-29 15:06:53 +01:00
- import_tasks: config.yml
Allow haproxy role to pull images Change-Id: I094f1d35f60bf566ba7382504a7425f16ae975d8 Partially-Implements: blueprint pre-pull-images
2016-01-05 17:52:38 +00:00
Performance: optimize genconfig Config plays do not need to check containers. This avoids skipping tasks during the genconfig action. Ironic and Glance rolling upgrades are handled specially. Swift and Bifrost do not use the handlers at all. Partially-Implements: blueprint performance-improvements Change-Id: I140bf71d62e8f0932c96270d1f08940a5ba4542a
2020-07-30 14:36:15 +02:00
- import_tasks: check-containers.yml
Fix haproxy restarting twice per Ansible run Since haproxy is orchestrated via site.yml in a single play, it does not need flushing handlers as handlers run will happen at the end of this play. Change-Id: Ia3743575da707325be93c39b4a2bcae9211cacb2 Related-Bug: #1864810 Closes-Bug: #1875228
2020-04-26 21:51:20 +02:00
# NOTE(yoctozepto): haproxy role handlers should not be flushed early.
# site.yml handles all haproxy things in a dedicated play.
# This is to avoid extra haproxy service restart.
# See: https://bugs.launchpad.net/kolla-ansible/+bug/1875228
Copy Permalink