From 43d56b02153f1dd502d986fe15d3696159f65e15 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rados=C5=82aw=20Piliszek?= <radoslaw.piliszek@gmail.com>
Date: Mon, 21 Mar 2022 17:01:53 +0100
Subject: [PATCH] Deprecate enable_ironic_pxe_uefi
Change-Id: Icc13e3607c6d1dfa4e12d1ceaf9ea5546a22a12b
---
ansible/group_vars/all.yml | 1 +
etc/kolla/globals.yml | 1 -
...eprecate-enable_ironic_pxe_uefi-80ce3653029098ba.yaml | 9 +++++++++
3 files changed, 10 insertions(+), 1 deletion(-)
create mode 100644 releasenotes/notes/deprecate-enable_ironic_pxe_uefi-80ce3653029098ba.yaml
diff --git a/ansible/group_vars/all.yml b/ansible/group_vars/all.yml
index fd0c86811a..3c8e2a7794 100644
--- a/ansible/group_vars/all.yml
+++ b/ansible/group_vars/all.yml
@@ -656,6 +656,7 @@ enable_horizon_zun: "{{ enable_zun | bool }}"
enable_influxdb: "{{ enable_monasca | bool or (enable_cloudkitty | bool and cloudkitty_storage_backend == 'influxdb') }}"
enable_ironic: "no"
enable_ironic_neutron_agent: "{{ enable_neutron | bool and enable_ironic | bool }}"
+# TODO(yoctozepto): Remove the deprecated enable_ironic_pxe_uefi in Zed.
enable_ironic_pxe_uefi: "no"
enable_iscsid: "{{ enable_cinder | bool and enable_cinder_backend_iscsi | bool }}"
enable_kafka: "{{ enable_monasca | bool }}"
diff --git a/etc/kolla/globals.yml b/etc/kolla/globals.yml
index ffe5fdbeed..b6384459a2 100644
--- a/etc/kolla/globals.yml
+++ b/etc/kolla/globals.yml
@@ -346,7 +346,6 @@
#enable_influxdb: "{{ enable_monasca | bool or (enable_cloudkitty | bool and cloudkitty_storage_backend == 'influxdb') }}"
#enable_ironic: "no"
#enable_ironic_neutron_agent: "{{ enable_neutron | bool and enable_ironic | bool }}"
-#enable_ironic_pxe_uefi: "no"
#enable_iscsid: "{{ enable_cinder | bool and enable_cinder_backend_iscsi | bool }}"
#enable_kafka: "{{ enable_monasca | bool }}"
#enable_kibana: "{{ 'yes' if enable_central_logging | bool or enable_monasca | bool else 'no' }}"
diff --git a/releasenotes/notes/deprecate-enable_ironic_pxe_uefi-80ce3653029098ba.yaml b/releasenotes/notes/deprecate-enable_ironic_pxe_uefi-80ce3653029098ba.yaml
new file mode 100644
index 0000000000..4458d850a2
--- /dev/null
+++ b/releasenotes/notes/deprecate-enable_ironic_pxe_uefi-80ce3653029098ba.yaml
@@ -0,0 +1,9 @@
+---
+deprecations:
+ - |
+ ``enable_ironic_pxe_uefi`` is deprecated and will be removed in Zed.
+ This variable is not documented and results in a broken PXE setup
+ for Ironic Inspector.
+ The recommended way to support EFI/UEFI deployments in Ironic
+ Inspector is to stay with the recommended default of iPXE in Ironic
+ Inspector (see docs on ``ironic_dnsmasq_serve_ipxe``).