CI: Use any_errors_fatal in pre.yml and run.yml

This ensures that failure of a single host fails the whole play at that
task. This can avoid confusing errors such as when the task
"Assert that the nodepool private IPv4 address is assigned" fails on one
host, causing subsequent errors on other hosts.

Note that this only affects the Zuul playbooks, not Kolla Ansible's
playbooks.

Change-Id: I77a6534dd2ddd188f795e17d17a44be249d01f31
This commit is contained in:
Mark Goddard 2019-10-06 08:02:42 +01:00
parent 42bfc53375
commit fac1670433
2 changed files with 6 additions and 0 deletions

@ -1,5 +1,6 @@
---
- hosts: all
any_errors_fatal: true
vars:
logs_dir: "/tmp/logs"
tasks:

@ -1,5 +1,6 @@
---
- hosts: all
any_errors_fatal: true
tasks:
# NOTE(yoctozepto): ensure we pick up fact changes from pre
- name: Refresh facts
@ -28,6 +29,7 @@
ceph_storetype: "{{ hostvars[inventory_hostname].get('ceph_osd_storetype') }}"
- hosts: primary
any_errors_fatal: true
tasks:
- name: detect whether need build images
set_fact:
@ -252,6 +254,7 @@
# NOTE(yoctozepto): each host checks itself
- hosts: all
any_errors_fatal: true
tasks:
- name: Pre-upgrade sanity checks
block:
@ -277,6 +280,7 @@
when: is_upgrade
- hosts: primary
any_errors_fatal: true
tasks:
# Upgrade: update config.
- block:
@ -386,6 +390,7 @@
# NOTE(yoctozepto): each host checks itself
- hosts: all
any_errors_fatal: true
tasks:
- name: Run check-failure.sh script
shell: