openstack/openstack-ansible-galera_server
Code Issues Proposed changes

Correct failure when stopping cluster state is ignored

Browse Source 
If the user passes in the `galera_ignore_cluster_state=true` flag, like
in the case of a node addition or a rolling replacement of nodes,
this role will fail to execute on all new nodes due to the existance of
a functioning cluster galera cluster. The first task in the pre-upgrade
steps attempts to stop the mysql service prior to running anything else.
This change makes it so the mysql service will not fail to stop on this
pre-upgrade task when the `galera_ignore_cluster_state=true` is passed
through.

Change-Id: Id9c4f11b3536e7f9d510f5ef8e6d82a82a96adac
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
This commit is contained in:
Kevin Carter 2018-10-01 19:00:51 -05:00
parent 10652dec2f
commit 068bb72999
No known key found for this signature in database
GPG Key ID: 9443251A787B9FB3
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tasks/galera_upgrade_pre.yml
View File

@ -14,9 +14,10 @@
# limitations under the License. # limitations under the License.
- name: Stop MariaDB - name: Stop MariaDB
service: systemd:
name: mysql name: mysql
state: stopped state: stopped
failed_when: "{{ (not galera_ignore_cluster_state | bool) | default(omit, false) }}"
register: galera_restart_fall_back register: galera_restart_fall_back
until: galera_restart_fall_back is success until: galera_restart_fall_back is success
retries: 3 retries: 3