openstack/openstack-ansible-galera_server
Code Issues Proposed changes

removed duplicate key

Browse Source 
In review of this role it was discovered that we had a duplicate
key within a task. While this is acceptable in Ansible as it will
just use the last key found in a given task it is wrong and should
be removed. In later version of Ansible (2.1.0) a warning is printed
stating something similar to the following:

   [WARNING]: While constructing a mapping from xxx.yml, line xx,
     column xx, found a duplicate dict key (changed_when).  Using
     last defined value only. [WARNING]: While constructing a mapping
     from xxx.yml, line xx, column xx, found a duplicate dict key
     (changed_when).  Using last defined value only.

This chage cleans up the role by removing the duplication.

Change-Id: I216987614b7783b9250c5ddc62bfae433423e775
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
This commit is contained in:
Kevin Carter 2016-03-31 01:03:47 -05:00
parent a0eda70cf8
commit ff665afd1a
No known key found for this signature in database
GPG Key ID: 69FEFFC5E2D9273F
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tasks/galera_running_check.yml
View File

@ -15,7 +15,6 @@
- name: Confirm service connectivity
command: "/usr/bin/mysqladmin --defaults-file=/etc/mysql/debian.cnf ping"
changed_when: _mysql_running.rc != 0
register: _mysql_running
until: _mysql_running.rc == 0
retries: "{{ num_retries }}"