From ff665afd1a177d65b8a4131a952f2af8b6aa61da Mon Sep 17 00:00:00 2001 From: Kevin Carter Date: Thu, 31 Mar 2016 01:03:47 -0500 Subject: [PATCH] removed duplicate key In review of this role it was discovered that we had a duplicate key within a task. While this is acceptable in Ansible as it will just use the last key found in a given task it is wrong and should be removed. In later version of Ansible (2.1.0) a warning is printed stating something similar to the following: [WARNING]: While constructing a mapping from xxx.yml, line xx, column xx, found a duplicate dict key (changed_when). Using last defined value only. [WARNING]: While constructing a mapping from xxx.yml, line xx, column xx, found a duplicate dict key (changed_when). Using last defined value only. This chage cleans up the role by removing the duplication. Change-Id: I216987614b7783b9250c5ddc62bfae433423e775 Signed-off-by: Kevin Carter --- tasks/galera_running_check.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/tasks/galera_running_check.yml b/tasks/galera_running_check.yml index c2c22f96..c56059a7 100644 --- a/tasks/galera_running_check.yml +++ b/tasks/galera_running_check.yml @@ -15,7 +15,6 @@ - name: Confirm service connectivity command: "/usr/bin/mysqladmin --defaults-file=/etc/mysql/debian.cnf ping" - changed_when: _mysql_running.rc != 0 register: _mysql_running until: _mysql_running.rc == 0 retries: "{{ num_retries }}"