From 450a879403656e45c5b89ccd6694b901bf520143 Mon Sep 17 00:00:00 2001
From: Jesse Pretorius <jesse.pretorius@rackspace.co.uk>
Date: Tue, 26 Jun 2018 09:58:59 +0100
Subject: [PATCH] MNAIO: Set tftp/pxe directory permissions using file module

Instead of using the shell module, we use the file module. It
achieves the same result idempotently.

Change-Id: I84adb76ee5d5a9e7dd56c15f7cdf8e220b841b23
---
 multi-node-aio/playbooks/deploy-pxe.yml | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/multi-node-aio/playbooks/deploy-pxe.yml b/multi-node-aio/playbooks/deploy-pxe.yml
index 2980aa83..22531b50 100644
--- a/multi-node-aio/playbooks/deploy-pxe.yml
+++ b/multi-node-aio/playbooks/deploy-pxe.yml
@@ -203,11 +203,13 @@
       with_dict: "{{ images }}"
 
     - name: Ensure permissions are correct
-      shell: |
-        # Fix perms if needed
-        find /var/lib/tftpboot -type d -exec chmod 0755 {} \;
-        find /var/lib/tftpboot -type f -exec chmod 0644 {} \;
-        find /var/www/pxe -type d -exec chmod 0755 {} \;
+      file:
+        dest: "{{ item }}"
+        mode: u=rwX,g=rX,o=rX
+        recurse: yes
+      with_items:
+        - "/var/lib/tftpboot"
+        - "/var/www/pxe"
 
   environment: "{{ deployment_environment_variables | default({}) }}"